#412 MultiPolygon::rotate should use centroid as pivot #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the associated issue |
|
To criticize my own work... I have copied the project wide practise of copying over numerical rounding error into the expected test output for example the value -0.9999999999999999 when -1 was desired In a separate issue I want to fix this .. hence I have created a new issue |
michaelkirk
reviewed
Dec 8, 2020
| T: Float, | ||
| Self: Sized, | ||
| { | ||
| self.rotate_around_point(angle, self.centroid()) |
There was a problem hiding this comment.
I had some input which I thought would be better to discuss in the issue rather than the PR, please see here: #412 (comment)
Curious about your opinion here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the solution with tests.