updating peerDependency to webpack 5 #126
Conversation
package.json
Outdated
| @@ -37,7 +37,7 @@ | |||
| ] | |||
| }, | |||
| "peerDependencies": { | |||
| "webpack": "^4.0.0" | |||
| "webpack": "^5.0.0" | |||
There was a problem hiding this comment.
shouldn't this be ^4.0.0 || ^5.0.0 as the plugin still support webpack 4 (as you did not change anything) ?
|
I've fixed the peerDependency to allow v4 or v5 and I should have the tests running in both v4 and... though the tests do not show up here for some reason. I can see my latest build, for example, here: https://travis-ci.org/github/geowarin/friendly-errors-webpack-plugin/builds/758364013 - but in Webpack 4, one test was already failing. |
| @@ -7,7 +7,10 @@ | |||
| "node": ">=8.0.0" | |||
| }, | |||
| "scripts": { | |||
| "test": "eslint --ignore-pattern 'test/*' . && jest" | |||
| "test": "yarn run test:webpack4 && yan run @test:webpack5", | |||
| @@ -7,7 +7,10 @@ | |||
| "node": ">=8.0.0" | |||
| }, | |||
| "scripts": { | |||
| "test": "eslint --ignore-pattern 'test/*' . && jest" | |||
| "test": "yarn run test:webpack4 && yan run @test:webpack5", | |||
| "test:webpack4": "eslint --ignore-pattern 'test/*' . && jest", | |||
There was a problem hiding this comment.
eslint --ignore-pattern 'test/*' is not really about testing webpack 4. This should be stay in test
|
Hi @geowarin, would you have some time to take a look at this PR ? :) |
|
Hi @geowarin any chance to take a look at this ? This plugin is used in |
|
Last commit on master 23 Dec 2019, last release in April 2018. This plugin looks like dead to me? |
|
嗨@geowarin，你有时间看看这个公关吗？ 😁 |
Fixes #123
As far as I can tell, this works fine with Webpack 5 (but ideally the tests can tell us more).
Cheers!