Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Animation #3

wants to merge 7 commits into from

Conversation

totetmatt
Copy link
Contributor

Working state for the animation on hoover (reverse need to be done)

Also, using System.nanoTime(), but I'm gonna try to use glfwGetTime() (just need to find where to put that)

Would also be a good thing to find a way to setup common uniform per program (currenty need to copy things across all program) and to put color process more on the frament shader to keep vertex shader only for geometry / vertex operation

@eduramiba
Copy link
Member

Hi Mathieu, thank you! Looks good on a first skim but we want to avoid static variables/global state altogether. We will have to keep state about time or anything in the VizEngine instance or lookup object instead.

Ideally a viz engine instance could live with another instance and have 2 windows with the same java program, for example.

@totetmatt
Copy link
Contributor Author

Hi Mathieu, thank you! Looks good on a first skim but we want to avoid static variables/global state altogether. We will have to keep state about time or anything in the VizEngine instance or lookup object instead.

Ideally a viz engine instance could live with another instance and have 2 windows with the same java program, for example.

Yeah definitively correct. I was exploring a little bit the code to understand it but still on the learning track.
I'll try to take that into concideration . Every "global variable" should be at VizEngine level

@eduramiba eduramiba self-assigned this Jan 6, 2022
@eduramiba eduramiba added the enhancement New feature or request label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants