Update Quickstart Apps with New Init flow #46

skylerjokiel · 2025-03-03T18:41:43Z

This more complex flow is required for our new Self-hosted model on the BP side.

❗Note: This change also requires coordination with the Docs to update the Configure Ditto section of the Quickstarts.

Apps

biozal · 2025-03-03T19:43:47Z

added Kotlin support - ran locally and app still works after changes.

…- added comments linking to docs

biozal · 2025-03-03T21:14:35Z

Updated to include Android Java and Rust

…it breaks Javascript which reads in the file and assumes Ditto is the prefix for all environment values

biozal · 2025-03-03T21:54:48Z

Update: I've updated the Swift and Sample file because Javascript needs the prefix DITTO in front of all values in the env file in order to read them. This will make all values in the .env file consistent.

…minal setup

skylerjokiel

Some small nits.

...oid-kotlin/QuickStartTasks/app/src/main/java/live/ditto/quickstart/tasks/TasksApplication.kt

rust-tui/src/bin/main.rs

javascript-web/src/App.tsx

rust-tui/src/bin/main.rs

…ickstart/tasks/TasksApplication.kt Co-authored-by: Skyler Jokiel <skjokiel@microsoft.com>

Co-authored-by: Skyler Jokiel <skjokiel@microsoft.com>

biozal · 2025-03-03T23:19:57Z

Some small nits.

Cleaned up.

biozal · 2025-03-18T14:29:07Z

Updated .NET to 4.10 and customUrl

biozal · 2025-03-19T18:01:59Z

Updated Android CPP and CPP Tui.

biozal · 2025-03-19T19:38:08Z

This is now ready for review.

nicholastmosher

I didn't try building anything, but I did a visual check of the following quickstarts and they all look good to me ✅

android-java
flutter_app
javscript-tui
javascript-web
react-native
rust-tui

I'd recommend somebody else check on the others:

android-cpp
android-kotlin
cpp-tui
dotnet-maui
dotnet-tui
swift

android-cpp/QuickStartTasksCPP/app/src/main/cpp/tasks_peer.cpp

skylerjokiel

Looks good to me. Added some nits.

dotnet-tui/DittoDotNetTasksConsole/TasksPeer.cs

flutter_app/lib/main.dart

javascript-tui/source/cli.js

javascript-web/src/App.tsx

react-native/App.tsx

Co-authored-by: Skyler Jokiel <skjokiel@microsoft.com>

biozal · 2025-03-20T13:11:56Z

All comments were resolved - comments were added to explain disabling cloud sync.

kristopherjohnson

I made comments about a couple of nits, but didn't see anything that should prevent merging.

For the C++ code, I've been using clang-format to provide consistent formatting for all the C++ files. There is a make format target in each of the Makefiles for C++ projects that will apply it. Arguably, clang-format's default style is not easily readable for tutorial-style code, so maybe we could tweak the style for this repo, but I'd like to keep auto-formatting code in this repo if we can.

cpp-tui/taskscpp/src/main.cpp

...oid-kotlin/QuickStartTasks/app/src/main/java/live/ditto/quickstart/tasks/TasksApplication.kt

pvditto · 2025-03-21T12:08:58Z

javascript-tui/source/cli.js

+const transportConfig = new TransportConfig();
+transportConfig.connect.websocketURLs.push(websocketURL);
+transportConfig.setAllPeerToPeerEnabled(true);
+ditto.setTransportConfig(transportConfig);


Why is this not using ditto.updateTransportConfig()? This has some implications because TransportConfig has different defaults than Ditto.transportConfig and I thought our guidance had been to use updateTransportConfig() in general. @skylerjokiel

Yep, always use updateTransportConfig().

konstantinbe · 2025-03-21T13:02:02Z

swift/tasks/tasks/DittoManager.swift

+        // Set the Ditto Websocket URL
+        var config = DittoTransportConfig()
+        config.connect.webSocketURLs.insert(Env.DITTO_WEBSOCKET_URL)
+
+        // Enable all P2P transports
+        config.enableAllPeerToPeer()
+        ditto.transportConfig = config


As pointed out by @pvditto, this should be using updateTransportConfig():

Suggested change

// Set the Ditto Websocket URL

var config = DittoTransportConfig()

config.connect.webSocketURLs.insert(Env.DITTO_WEBSOCKET_URL)

// Enable all P2P transports

config.enableAllPeerToPeer()

ditto.transportConfig = config

// Add the Ditto Websocket URL

ditto.updateTransportConfig { transportConfig in

transportConfig.connect.webSocketURLs.insert(Env.DITTO_WEBSOCKET_URL)

}

skylerjokiel added 2 commits March 3, 2025 10:38

Update swift quickstart initialization with new syntax

3e93f87

fix env.sample

2e913fb

biozal approved these changes Mar 3, 2025

View reviewed changes

fix: updated to include Android Kotlin fixes

41f2802

biozal self-requested a review March 3, 2025 19:42

biozal added 3 commits March 3, 2025 14:06

fix: updated Android implementation for custom URL and websocket Url …

ebba924

…- added comments linking to docs

doc: updated kotlin code with links to docs

b3c6533

updated to include Rust support

9c39cee

biozal added 2 commits March 3, 2025 15:48

fix: updated javascript-web with comments and using customURL

03e8e4c

fix: fixed Swift to use DITTO for prefix because without that prefix …

2b721fa

…it breaks Javascript which reads in the file and assumes Ditto is the prefix for all environment values

biozal added 3 commits March 3, 2025 16:43

update: standardized readme files and names of environment variables

72b5602

updated React Native readme with notes about possible issues with ter…

5240feb

…minal setup

updated to fix kotlin having wrong auth env name

c4ddf94

skylerjokiel commented Mar 3, 2025

View reviewed changes

biozal and others added 5 commits March 3, 2025 17:14

Update android-kotlin/QuickStartTasks/app/src/main/java/live/ditto/qu…

717a253

…ickstart/tasks/TasksApplication.kt Co-authored-by: Skyler Jokiel <skjokiel@microsoft.com>

Update javascript-web/src/App.tsx

9432b19

Co-authored-by: Skyler Jokiel <skjokiel@microsoft.com>

Update rust-tui/src/bin/main.rs

56d481c

Co-authored-by: Skyler Jokiel <skjokiel@microsoft.com>

Update rust-tui/src/bin/main.rs

f89c714

Co-authored-by: Skyler Jokiel <skjokiel@microsoft.com>

removed extra logging statement added by accident

4554b26

biozal added 2 commits March 18, 2025 08:52

updated for Android to remove logging

3b075d6

updated .NET projects to latest 4.10 release and customUrl

3b745c4

biozal added 4 commits March 18, 2025 09:55

fixed: updated Flutter to 4.10 and customUrl/websocket

04fb09f

fixed .NET to include websocket URL

e1cd594

updated Android, flutter description and updated Swift to 4.10.0

9e7cbc2

fixed updated Android kotlin and java to 4.10.0

d3d3ce7

biozal marked this pull request as ready for review March 19, 2025 18:01

biozal requested review from phatblat, konstantinbe, kristopherjohnson, danielhenrymantilla, teodorciuraru, pvditto, busec0, anyercastillo and a team as code owners March 19, 2025 18:01

nicholastmosher reviewed Mar 19, 2025

View reviewed changes

skylerjokiel commented Mar 19, 2025

View reviewed changes

android-cpp/QuickStartTasksCPP/app/src/main/cpp/tasks_peer.cpp Show resolved Hide resolved

skylerjokiel commented Mar 19, 2025

View reviewed changes

biozal and others added 4 commits March 20, 2025 07:40

Apply suggestions from code review

85b7a9c

Co-authored-by: Skyler Jokiel <skjokiel@microsoft.com>

updates based on feedback from PR

105b409

updates based on feedback from PR

152e767

added comments about having to disable cloud sync

4d9ec9e

biozal self-assigned this Mar 20, 2025

biozal added the enhancement New feature or request label Mar 20, 2025

biozal requested a review from nicholastmosher March 20, 2025 13:13

kristopherjohnson approved these changes Mar 20, 2025

View reviewed changes

cpp-tui/taskscpp/src/main.cpp Show resolved Hide resolved

...oid-kotlin/QuickStartTasks/app/src/main/java/live/ditto/quickstart/tasks/TasksApplication.kt Outdated Show resolved Hide resolved

biozal added 2 commits March 20, 2025 13:10

updated comment in kotlin

81d2f61

fix issue with missing websocket and auth url for parse with sync

53c6f7c

biozal merged commit 912643f into main Mar 20, 2025
3 checks passed

biozal deleted the update-initialization branch March 20, 2025 18:18

pvditto reviewed Mar 21, 2025

View reviewed changes

konstantinbe reviewed Mar 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Quickstart Apps with New Init flow #46

Update Quickstart Apps with New Init flow #46

skylerjokiel commented Mar 3, 2025 •

edited by biozal

Loading

biozal commented Mar 3, 2025

biozal commented Mar 3, 2025

biozal commented Mar 3, 2025

skylerjokiel left a comment

biozal commented Mar 3, 2025

biozal commented Mar 18, 2025

biozal commented Mar 19, 2025

biozal commented Mar 19, 2025

nicholastmosher left a comment

skylerjokiel left a comment

biozal commented Mar 20, 2025

kristopherjohnson left a comment •

edited

Loading

pvditto Mar 21, 2025

konstantinbe Mar 21, 2025

konstantinbe Mar 21, 2025 •

edited

Loading

Update Quickstart Apps with New Init flow #46

Update Quickstart Apps with New Init flow #46

Conversation

skylerjokiel commented Mar 3, 2025 • edited by biozal Loading

Apps

biozal commented Mar 3, 2025

biozal commented Mar 3, 2025

biozal commented Mar 3, 2025

skylerjokiel left a comment

Choose a reason for hiding this comment

biozal commented Mar 3, 2025

biozal commented Mar 18, 2025

biozal commented Mar 19, 2025

biozal commented Mar 19, 2025

nicholastmosher left a comment

Choose a reason for hiding this comment

skylerjokiel left a comment

Choose a reason for hiding this comment

biozal commented Mar 20, 2025

kristopherjohnson left a comment • edited Loading

Choose a reason for hiding this comment

pvditto Mar 21, 2025

Choose a reason for hiding this comment

konstantinbe Mar 21, 2025

Choose a reason for hiding this comment

konstantinbe Mar 21, 2025 • edited Loading

Choose a reason for hiding this comment

skylerjokiel commented Mar 3, 2025 •

edited by biozal

Loading

kristopherjohnson left a comment •

edited

Loading

konstantinbe Mar 21, 2025 •

edited

Loading