Add new tests to featuremap

[shashwatahalder01]

All Submissions:

• My code follow the WordPress' coding standards
• My code satisfies feature requirements
• My code is tested
• My code passes the PHPCS tests
• My code has proper inline documentation
• I've included related pull request(s) (optional)
• I've included developer documentation (optional)
• I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

• Full PR Link

Closes

• Closes #

How to test the changes in this Pull Request:

• Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

• Code is not following code style guidelines
• Bad naming: make sure you would understand your code if you read it a few months from now.
• KISS: Keep it simple, Sweetie (not stupid!).
• DRY: Don't Repeat Yourself.
• Code that is not readable: too many nested 'if's are a bad sign.
• Performance issues
• Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
• Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

• Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
• Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
• Readable — Will your future self be able to understand this change months down the road?
• Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

• New Features

  • Introduced a "Feature lock" page for admins with various license management features.
  • Added a "Seller Vacation" page with settings for both admin and vendor roles.

• Modifications

  • Adjusted feature settings across multiple existing pages, toggling functionalities on or off.
  • Corrected minor typos in feature descriptions, including capitalization changes.

• Bug Fixes

  • Updated test case title for clarity without impacting functionality.
  • Marked certain tests as skipped due to unmerged pull requests, ensuring stability in testing.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request introduce two new pages, "Feature lock" and "Seller Vacation," in the feature map for admin and vendor roles, respectively, with all functionalities initially set to false. Additionally, numerous existing pages have been modified to adjust feature settings, correct minor typos, and enhance the feature set. The modifications include changing feature states and updating test case names in the corresponding test files, while the overall test structure remains unchanged.

Changes

File Path	Change Summary
tests/pw/feature-map/feature-map.yml	Added pages: "Feature lock" (admin) and "Seller Vacation" (admin & vendor). Modified multiple pages to adjust feature settings and correct typos.
tests/pw/tests/e2e/followStore.spec.ts	Added a comment for future task regarding parameterization of tests; no functional changes made.
tests/pw/tests/e2e/wholesale.spec.ts	Updated test case title from "All users can see wholesale price" to "all users can see wholesale price"; no functional changes made.
tests/pw/tests/e2e/productsDetailsBookings.spec.ts	Changed test for importing a booking product addon from standard to skipped; no other changes made.
tests/pw/tests/e2e/vendorSettings.spec.ts	Marked two tests as skipped due to pending pull request; no other changes made.

Possibly related PRs

• Add product categories & tags tests  #2384: Modifications to the feature map configuration for various pages, including updates to vendor capabilities.
• Add: add product form tests (gallery, description) #2385: Introduces tests for product form functionalities related to features in the main PR.
• Add: product form tests (other options, catalog) #2391: Adds tests for product options targeting additional catalog functionalities.
• Add: add product form test(attribute, bulk discount, geolocation) #2395: Introduces tests for product attributes, bulk discounts, and geolocation features relevant to the expanded functionalities.
• Add: add product tests (product addon, rma) #2396: Adds tests for product addons and RMA options, directly related to the features expanded in the main PR.
• Add: add product form tests (wholesale, min-max) #2397: Introduces tests for wholesale and min-max pricing scenarios, directly related to the features expanded in the main PR.
• Add Geolocation tests #2445: Introduces geolocation tests, enhancing coverage for functionalities part of the feature set expanded in the main PR.
• Auction tests #2452: Introduces auction-related tests relevant to overall enhancements in product management and vendor capabilities.
• Add new tests to featuremap #2453: Introduces new tests to the feature map, which is relevant to the main PR's changes regarding the feature set for vendors.

Poem

In the meadow where features bloom,
A "Feature lock" to dispel the gloom.
With "Seller Vacation," we take a break,
New settings to ponder, for all our sake.
So hop along, let changes flow,
In the world of code, we watch it grow! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

tests/pw/feature-map/feature-map.yml (2)

654-661: LGTM! Consider adding documentation for the feature lock behavior.

The new feature lock implementation with default disabled states is appropriate. However, it would be beneficial to add documentation explaining:

• The conditions that trigger these features
• The expected behavior when each feature is enabled
• The impact on admin functionality

---

1256-1264: LGTM! Consider adding customer-facing features.

The seller vacation implementation looks good with appropriate default states. Consider adding customer-related features such as:

• Customer can view vendor vacation status
• Customer can see vacation message
• Customer can get notified when vendor returns

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1f97569 and 99f2a27.

📒 Files selected for processing (3)

• tests/pw/feature-map/feature-map.yml (12 hunks)
• tests/pw/tests/e2e/followStore.spec.ts (1 hunks)
• tests/pw/tests/e2e/wholesale.spec.ts (1 hunks)

✅ Files skipped from review due to trivial changes (2)

• tests/pw/tests/e2e/followStore.spec.ts
• tests/pw/tests/e2e/wholesale.spec.ts

🔇 Additional comments (2)

tests/pw/feature-map/feature-map.yml (2)

934-945: Verify the intentional disabling of payment gateway features.

Multiple payment gateway integrations (MangoPay, PayPal Marketplace, Razorpay, Stripe Connect, Stripe Express) have their features set to false. Please confirm if this is intentional as it may impact:

• Payment processing capabilities
• Vendor payment method configurations
• Customer checkout options

Also applies to: 963-973, 1123-1131, 1367-1378, 1383-1394

---

Line range hint 1153-1211: Review impact on customer-facing features.

Multiple customer-facing features have been disabled:

• RFQ functionality
• Warranty replacement requests
• Table rate shipping options

This could significantly impact the customer experience. Please ensure:

1. Customer communication about these changes is planned
2. Alternative options are available where necessary
3. UI/UX is updated to reflect these changes

Also applies to: 1230-1230, 1406-1408