Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Author name, URL, and email change #2536

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

shohag121
Copy link
Member

@shohag121 shohag121 commented Jan 27, 2025

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

  • Full PR Link

Closes

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

  • Metadata Updates
    • Updated author information across project files from "weDevs" to "Dokan Inc."
    • Modified copyright notice and contact email
    • Updated copyright year from 2019 to 2025
    • Changed GitHub repository link to reflect new branding
    • Updated contributor names and donation link in documentation to align with new branding

@shohag121 shohag121 added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Jan 27, 2025
@shohag121 shohag121 requested a review from mrabbani January 27, 2025 04:01
@shohag121 shohag121 self-assigned this Jan 27, 2025
Copy link
Contributor

coderabbitai bot commented Jan 27, 2025

Walkthrough

The pull request focuses on updating the author information for the Dokan WordPress plugin across multiple configuration files. The changes involve replacing "weDevs" with "Dokan Inc." in composer.json, dokan.php, package.json, and readme.txt. The modifications include updating the author name, email, copyright notice, and related metadata to reflect the new branding while maintaining the core plugin structure and functionality.

Changes

File Change Summary
composer.json Updated author name from "weDevs" to "Dokan Inc." and email from "[email protected]" to "[email protected]".
dokan.php - Updated author name to "Dokan Inc."
- Updated copyright year to 2025
- Modified author URI to point to "https://dokan.co/wordpress/".
package.json - Changed author from "weDevs" to "Dokan Inc."
- Updated makepot script copyright notice.
readme.txt - Updated author attribution to "Dokan"
- Changed GitHub repository link to "https://github.com/getdokan/dokan/"
- Updated donation link and contributor names.

Assessment against linked issues

Objective Addressed Explanation
Change plugin author from weDevs to Dokan Inc.
Hyperlink author name to Dokan website

Suggested labels

QA approved, Dev Review Done, Upcoming Release

Suggested reviewers

  • mrabbani

Poem

🐰 A rabbit's tale of rebranding delight,
Dokan Inc. takes its authorial flight!
From weDevs to a new name so bright,
Configuration files now shine just right,
A plugin's identity, crisp and tight! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e7f47e and 20748ad.

📒 Files selected for processing (1)
  • readme.txt (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • readme.txt
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: e2e tests (3, 3)
  • GitHub Check: e2e tests (2, 3)
  • GitHub Check: e2e tests (1, 3)
  • GitHub Check: api tests (1, 1)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@mrabbani mrabbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@getdokan/product, Pls check the all links in https://github.com/getdokan/dokan/blob/develop/readme.txt

@mrabbani
Copy link
Member

@getdokan/product , Following links should be checked

  1. Contributors: tareq1988, wedevs, nizamuddinbabu
  2. https://github.com/getdokan/dokan/blob/e97ff28080e92b5329b57a5605a9f2ba3b93ec43/readme.txt#L100C1-L101C1
  3. Redirected: https://github.com/getdokan/dokan/blob/e97ff28080e92b5329b57a5605a9f2ba3b93ec43/readme.txt#L182C46-L182C121
  4. Brought to you by [Tareq Hasan](http://tareq.co) from [weDevs](http://wedevs.com)

CC: @shohag121 vai.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e97ff28 and 2a7d9b1.

📒 Files selected for processing (3)
  • composer.json (1 hunks)
  • dokan.php (2 hunks)
  • package.json (2 hunks)
✅ Files skipped from review due to trivial changes (2)
  • package.json
  • dokan.php
🔇 Additional comments (2)
composer.json (2)

9-9: Verify the email address validity.

Please ensure that [email protected] is a valid and active email address.


8-9: Consider updating the package name for consistency.

While the author information has been updated to "Dokan Inc.", the package name "wedevs/dokan" and PSR-4 namespaces still reference "WeDevs". Consider if these should also be updated for brand consistency.

Note: Changing the package name and namespaces would be a breaking change requiring major version bump and migration documentation.

Run this script to analyze the impact:

@jamil-mahmud
Copy link

jamil-mahmud commented Jan 27, 2025

@mrabbani vai, Changes - -

  1. Contributors: tareq1988, wedevs, nizamuddinbabu
  1. https://github.com/getdokan/dokan/blob/e97ff28080e92b5329b57a5605a9f2ba3b93ec43/readme.txt#L100C1-L101C1
  • Will redirect to getdokan github
  1. Redirected: https://github.com/getdokan/dokan/blob/e97ff28080e92b5329b57a5605a9f2ba3b93ec43/readme.txt#L182C46-L182C121
  • Will remain as it is
  1. Brought to you by [Tareq Hasan](http://tareq.co) from [weDevs](http://wedevs.com)
  • Remove 4

Additionals:

@shohag121 shohag121 requested a review from mrabbani January 27, 2025 11:27
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
readme.txt (1)

288-288: Fix grammatical error in the contribution section.

Based on the static analysis hint, there's a grammatical error in the preposition usage.

Apply this diff to fix the grammar:

-If you want to contribute on this project, you are more than welcome.
+If you want to contribute to this project, you are more than welcome.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~288-~288: The preposition ‘to’ seems more likely in this position.
Context: ...any features. If you want to contribute on this project, you are more than welcome...

(AI_HYDRA_LEO_REPLACE_ON_TO)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5961953 and 5e7f47e.

📒 Files selected for processing (1)
  • readme.txt (6 hunks)
🧰 Additional context used
🪛 LanguageTool
readme.txt

[uncategorized] ~288-~288: The preposition ‘to’ seems more likely in this position.
Context: ...any features. If you want to contribute on this project, you are more than welcome...

(AI_HYDRA_LEO_REPLACE_ON_TO)

⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: e2e tests (3, 3)
  • GitHub Check: e2e tests (2, 3)
  • GitHub Check: e2e tests (1, 3)
  • GitHub Check: api tests (1, 1)
🔇 Additional comments (5)
readme.txt (5)

2-2: LGTM! Contributor list updated correctly.

The addition of "dokaninc" while retaining "wedevs" in the contributors list aligns with the PR objectives for the branding transition.


3-3: LGTM! Donation link updated appropriately.

The donation link has been updated from a personal URL to the official Dokan pricing page, which is more appropriate for a commercial plugin.


100-100: LGTM! GitHub repository link updated correctly.

The GitHub repository link has been updated from weDevsOfficial to getdokan organization.


228-228: LGTM! Changelog link updated appropriately.

The changelog link has been updated to point to the official Dokan changelog page.


277-277: LGTM! Repository fork link updated correctly.

The repository fork link has been updated to point to the new GitHub organization.

@mrabbani mrabbani added 👍 Dev Review Done Upcoming Release and removed PM Dependency Needs: Dev Review It requires a developer review and approval labels Jan 28, 2025
@shashwatahalder01 shashwatahalder01 added QA In Progress QA approved This PR is approved by the QA team and removed Needs: Testing This requires further testing QA In Progress labels Jan 28, 2025
@shohag121 shohag121 merged commit 8368ef6 into develop Jan 28, 2025
6 checks passed
@shohag121 shohag121 deleted the chore/change-plugin-author-details branch January 28, 2025 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance - Author change in WP Org
4 participants