-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Author name, URL, and email change #2536
Conversation
WalkthroughThe pull request focuses on updating the author information for the Dokan WordPress plugin across multiple configuration files. The changes involve replacing "weDevs" with "Dokan Inc." in Changes
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getdokan/product, Pls check the all links in https://github.com/getdokan/dokan/blob/develop/readme.txt
@getdokan/product , Following links should be checked
CC: @shohag121 vai. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
composer.json
(1 hunks)dokan.php
(2 hunks)package.json
(2 hunks)
✅ Files skipped from review due to trivial changes (2)
- package.json
- dokan.php
🔇 Additional comments (2)
composer.json (2)
9-9
: Verify the email address validity.Please ensure that [email protected] is a valid and active email address.
8-9
: Consider updating the package name for consistency.While the author information has been updated to "Dokan Inc.", the package name "wedevs/dokan" and PSR-4 namespaces still reference "WeDevs". Consider if these should also be updated for brand consistency.
Note: Changing the package name and namespaces would be a breaking change requiring major version bump and migration documentation.
Run this script to analyze the impact:
@mrabbani vai, Changes - -
Additionals:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
readme.txt (1)
288-288
: Fix grammatical error in the contribution section.Based on the static analysis hint, there's a grammatical error in the preposition usage.
Apply this diff to fix the grammar:
-If you want to contribute on this project, you are more than welcome. +If you want to contribute to this project, you are more than welcome.🧰 Tools
🪛 LanguageTool
[uncategorized] ~288-~288: The preposition ‘to’ seems more likely in this position.
Context: ...any features. If you want to contribute on this project, you are more than welcome...(AI_HYDRA_LEO_REPLACE_ON_TO)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
readme.txt
(6 hunks)
🧰 Additional context used
🪛 LanguageTool
readme.txt
[uncategorized] ~288-~288: The preposition ‘to’ seems more likely in this position.
Context: ...any features. If you want to contribute on this project, you are more than welcome...
(AI_HYDRA_LEO_REPLACE_ON_TO)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: e2e tests (3, 3)
- GitHub Check: e2e tests (2, 3)
- GitHub Check: e2e tests (1, 3)
- GitHub Check: api tests (1, 1)
🔇 Additional comments (5)
readme.txt (5)
2-2
: LGTM! Contributor list updated correctly.The addition of "dokaninc" while retaining "wedevs" in the contributors list aligns with the PR objectives for the branding transition.
3-3
: LGTM! Donation link updated appropriately.The donation link has been updated from a personal URL to the official Dokan pricing page, which is more appropriate for a commercial plugin.
100-100
: LGTM! GitHub repository link updated correctly.The GitHub repository link has been updated from weDevsOfficial to getdokan organization.
228-228
: LGTM! Changelog link updated appropriately.The changelog link has been updated to point to the official Dokan changelog page.
277-277
: LGTM! Repository fork link updated correctly.The repository fork link has been updated to point to the new GitHub organization.
All Submissions:
Changes proposed in this Pull Request:
Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
Title
Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Describe the issue after changes with screenshot(s).
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit