Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed an color issue for the icon/text-on-highlight-subdued token #487

Merged
merged 4 commits into from
Dec 13, 2023
Merged

fixed an color issue for the icon/text-on-highlight-subdued token #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2bc3c1c
fixed an color issue for the text-on-highlight-subdued
FlipOps Dec 13, 2023
604b377
feat(tokens): update design tokens (triggered by Figma)
FlipOps Dec 13, 2023
c8d36f0
chore(tokens): add changeset
Sqrrl Dec 13, 2023
d1fffac
Merge branch 'main' into figma-tokens
Sqrrl Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-days-help.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@getflip/swirl-tokens": patch
---

Fix a minor issue with a color token
10 changes: 5 additions & 5 deletions packages/swirl-tokens/dart/lib/styles.dark.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//

// Do not edit directly
// Generated on Mon, 11 Dec 2023 15:37:50 GMT
// Generated on Wed, 13 Dec 2023 08:24:26 GMT



Expand Down Expand Up @@ -122,7 +122,7 @@ class SwirlDesignTokensDark {
static const coreGrayWhite = Color(0xFFFFFFFF);
static const coreOnCustomerColorDark1 = Color(0xFF000000);
static const coreOnCustomerColorDark2 = Color(0xFFF2F2F2);
static const coreOnCustomerColorDark2Subdued = Color(0xFF5C76AE);
static const coreOnCustomerColorDark2Subdued = Color(0xFF96A3BF);
static const coreOnCustomerColorLight1 = Color(0xFFFFFFFF);
static const coreOnCustomerColorLight2 = Color(0xFF171717);
static const coreOnCustomerColorLight2Subdued = Color(0xFF6A6D74);
Expand Down Expand Up @@ -197,7 +197,7 @@ class SwirlDesignTokensDark {
static const iconOnImage = Color(0xFFFFFFFF); /* Used as a icon color on “Surface On Image/Default”. */
static const iconOnStatus = Color(0xFF000000); /* Used as a icon color on containers with a status color. */
static const iconOnSurfaceHighlight = Color(0xFFF2F2F2); /* Used as icon color on containers with highlight color. */
static const iconOnSurfaceHighlightSubdued = Color(0xFF5C76AE); /* Used as icon color on containers with highlight color. */
static const iconOnSurfaceHighlightSubdued = Color(0xFF96A3BF); /* Used as icon color on containers with highlight color. */
static const iconStrong = Color(0xFFF2F2F2); /* Used for high emphasis icons. */
static const iconSuccess = Color(0xFF50A450); /* Used as success icon color */
static const iconWarning = Color(0xFFF3B703); /* Used as warning icon color */
Expand Down Expand Up @@ -273,7 +273,7 @@ class SwirlDesignTokensDark {
static const textOnImage = Color(0xFFFFFFFF); /* Used as a text color on “Surface On Image/Default”. */
static const textOnStatus = Color(0xFF000000); /* Used as a text color on containers with a status color. */
static const textOnSurfaceHighlight = Color(0xFFF2F2F2); /* Used as text color on containers with highlight color. */
static const textOnSurfaceHighlightSubdued = Color(0xFF5C76AE); /* Used as text color on containers with highlight color. */
static const textOnSurfaceHighlightSubdued = Color(0xFF96A3BF); /* Used as text color on containers with highlight color. */
static const textSubdued = Color(0xFF989898); /* Used for low emphasis text. */
static const textSuccess = Color(0xFF50A450); /* Used as success text color */
static const textWarning = Color(0xFFF3B703); /* Used as warning text color */
Expand All @@ -284,4 +284,4 @@ class SwirlDesignTokensDark {
static const z40 = "40";
static const z50 = "50";
static const zAuto = "auto";
}
}
6 changes: 3 additions & 3 deletions packages/swirl-tokens/dart/lib/styles.light.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
//

// Do not edit directly
// Generated on Mon, 11 Dec 2023 15:37:50 GMT
// Generated on Wed, 13 Dec 2023 08:24:26 GMT



Expand Down Expand Up @@ -122,7 +122,7 @@ class SwirlDesignTokensLight {
static const coreGrayWhite = Color(0xFFFFFFFF);
static const coreOnCustomerColorDark1 = Color(0xFF000000);
static const coreOnCustomerColorDark2 = Color(0xFFF2F2F2);
static const coreOnCustomerColorDark2Subdued = Color(0xFF5C76AE);
static const coreOnCustomerColorDark2Subdued = Color(0xFF96A3BF);
static const coreOnCustomerColorLight1 = Color(0xFFFFFFFF);
static const coreOnCustomerColorLight2 = Color(0xFF171717);
static const coreOnCustomerColorLight2Subdued = Color(0xFF6A6D74);
Expand Down Expand Up @@ -284,4 +284,4 @@ class SwirlDesignTokensLight {
static const z40 = "40";
static const z50 = "50";
static const zAuto = "auto";
}
}
11 changes: 8 additions & 3 deletions packages/swirl-tokens/figma-tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@
"type": "color"
},
"2-subdued": {
"value": "#5C76AE",
"value": "#96A3BF",
"type": "color"
}
},
Expand Down Expand Up @@ -2653,6 +2653,11 @@
}
],
"$metadata": {
"tokenSetOrder": ["core", "core-colors", "light", "dark"]
"tokenSetOrder": [
"core",
"core-colors",
"light",
"dark"
]
}
}
}
2 changes: 1 addition & 1 deletion packages/swirl-tokens/tokens/tokens.dark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@
"type": "color"
},
"core-on-customer-color-dark-2-subdued": {
"value": "rgba(92, 118, 174, 1)",
"value": "rgba(150, 163, 191, 1)",
"type": "color"
},
"core-status-light-critical-default": {
Expand Down
2 changes: 1 addition & 1 deletion packages/swirl-tokens/tokens/tokens.light.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@
"type": "color"
},
"core-on-customer-color-dark-2-subdued": {
"value": "rgba(92, 118, 174, 1)",
"value": "rgba(150, 163, 191, 1)",
"type": "color"
},
"core-status-light-critical-default": {
Expand Down
Loading