Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2xl thumbnail size #741

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Add 2xl thumbnail size #741

merged 6 commits into from
Jun 26, 2024

Conversation

AshleyBekemeier
Copy link
Collaborator

Summary

Review Checklist

General

  • Changeset added
  • The submitted code is organized and formatted according to our 💅 Style Guide.
    • The code is formatted with Prettier.
    • There are no linting errors.

For new or updated components

https://swirl-storybook.flip-app.dev/?path=/docs/contributions-merge-publish--page

  • The changes do not contain any breaking changes.
  • The changes do not introduce new components that don't belong in the library (e.g. non-reusable components, highly specialized components, components including business logic)
  • The component documentation is updated.
  • The changes meet the 🤖 testing requirements.
    • New features are tested.
    • In case of bug fixes, regression tests have been added.
    • All tests are 🟢.
  • The changes meet the 🧏‍♀️ accessibility requirements.
    • WCAG 2.1 Level A and Level AA requirements are met.
    • The Storybook a11y addon shows no errors.
    • The changes have been tested with a screen reader.
    • Keyboard controls have been tested, if applicable.
    • Components implementing form controls (inputs, buttons, selects, etc.) do not use Shadow DOM, and instead use Stencil's scoping mechanism
  • The changes use our 🌈 theming concept.
    • Design tokens have been used where appropriate.
    • The component has been visually checked in combination with the "Light" and "Dark" theme.
  • The changes meet our 🌍 internationalization requirements.
    • No static text is used.
    • The component doesn't break with longer texts or different text wrappings.
    • Number, currency and date values can be formatted appropriately.
  • The changes work in all supported browsers and viewports. See 📱 Responsive Design

@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
getflipdev ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 8:42am
staginggetflipdev ⬜️ Ignored (Inspect) Visit Preview Jun 26, 2024 8:42am

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-741.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-741.westeurope.3.azurestaticapps.net

maraikeschneider
maraikeschneider approved these changes Jun 25, 2024
View reviewed changes
packages/swirl-components/src/components/swirl-thumbnail/swirl-thumbnail.stories.ts
Comment on lines 6 to +8
showRemoveButton: {
description: "Only displayed with size `xl` and format `square`.",
description:
"Only displayed with size `xl` or `2xl` and format `square`.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Maybe we can add this information to showEditButton as description as well. Plus, we could mention that it is not displayed if showRemoveButton === true && size === 'xl'

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-741.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-741.westeurope.3.azurestaticapps.net

@AshleyBekemeier AshleyBekemeier merged commit 477631b into main Jun 26, 2024
9 checks passed
@AshleyBekemeier AshleyBekemeier deleted the add-2xl-thumbnail-size branch June 26, 2024 08:54
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraikeschneider maraikeschneider maraikeschneider approved these changes

@Sqrrl Sqrrl Awaiting requested review from Sqrrl Sqrrl is a code owner

@webspaceadam webspaceadam Awaiting requested review from webspaceadam

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshleyBekemeier @maraikeschneider