Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional gradient to SwirlCarousel #918

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Add optional gradient to SwirlCarousel #918

merged 6 commits into from
Jan 23, 2025

Conversation

danizep
Copy link
Collaborator

@danizep danizep commented Jan 21, 2025

Summary

Review Checklist

General

  • Changeset added
  • The submitted code is organized and formatted according to our 💅 Style Guide.
    • The code is formatted with Prettier.
    • There are no linting errors.

For new or updated components

https://swirl-storybook.flip-app.dev/?path=/docs/contributions-merge-publish--page

  • The changes do not contain any breaking changes.
  • The changes do not introduce new components that don't belong in the library (e.g. non-reusable components, highly specialized components, components including business logic)
  • The component documentation is updated.
  • The changes meet the 🤖 testing requirements.
    • New features are tested.
    • In case of bug fixes, regression tests have been added.
    • All tests are 🟢.
  • The changes meet the 🧏‍♀️ accessibility requirements.
    • WCAG 2.1 Level A and Level AA requirements are met.
    • The Storybook a11y addon shows no errors.
    • The changes have been tested with a screen reader.
    • Keyboard controls have been tested, if applicable.
    • Components implementing form controls (inputs, buttons, selects, etc.) do not use Shadow DOM, and instead use Stencil's scoping mechanism
  • The changes use our 🌈 theming concept.
    • Design tokens have been used where appropriate.
    • The component has been visually checked in combination with the "Light" and "Dark" theme.
  • The changes meet our 🌍 internationalization requirements.
    • No static text is used.
    • The component doesn't break with longer texts or different text wrappings.
    • Number, currency and date values can be formatted appropriately.
  • The changes work in all supported browsers and viewports. See 📱 Responsive Design

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-918.westeurope.3.azurestaticapps.net

@danizep danizep force-pushed the add-optional-gradient-to-the-edge-of-the-carousel branch from 79d3e8b to 88da02d Compare January 22, 2025 10:57
@vercel Vercel
Copy link

vercel bot commented Jan 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
getflipdev ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 3:27pm
staginggetflipdev ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 3:27pm

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-918.westeurope.3.azurestaticapps.net

@danizep danizep force-pushed the add-optional-gradient-to-the-edge-of-the-carousel branch from 88da02d to 95a5474 Compare January 22, 2025 11:19
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-918.westeurope.3.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-918.westeurope.3.azurestaticapps.net

@danizep danizep marked this pull request as ready for review January 23, 2025 12:17
@danizep danizep requested a review from Sqrrl as a code owner January 23, 2025 12:17
@danizep danizep force-pushed the add-optional-gradient-to-the-edge-of-the-carousel branch from bc04488 to 77ce400 Compare January 23, 2025 15:27
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-918.westeurope.3.azurestaticapps.net

@danizep danizep merged commit 8731ea8 into main Jan 23, 2025
9 checks passed
@danizep danizep deleted the add-optional-gradient-to-the-edge-of-the-carousel branch January 23, 2025 15:51
@github-actions github-actions bot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sqrrl Sqrrl Sqrrl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danizep @Sqrrl