Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak resource list keyboard controls #925

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Tweak resource list keyboard controls #925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/eleven-pigs-look.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@getflip/swirl-components": minor
"@getflip/swirl-components-angular": minor
"@getflip/swirl-components-react": minor
---

Only activate items of swirl-resource-list via Enter when having a controlling
element
16 changes: 16 additions & 0 deletions packages/swirl-components/src/components.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2441,6 +2441,10 @@ export interface SwirlBannerCustomEvent<T> extends CustomEvent<T> {
detail: T;
target: HTMLSwirlBannerElement;
}
export interface SwirlBoxCustomEvent<T> extends CustomEvent<T> {
detail: T;
target: HTMLSwirlBoxElement;
}
export interface SwirlCardCustomEvent<T> extends CustomEvent<T> {
detail: T;
target: HTMLSwirlCardElement;
Expand Down Expand Up @@ -2804,7 +2808,18 @@ declare global {
prototype: HTMLSwirlBannerElement;
new (): HTMLSwirlBannerElement;
};
interface HTMLSwirlBoxElementEventMap {
"componentLoad": void;
}
interface HTMLSwirlBoxElement extends Components.SwirlBox, HTMLStencilElement {
addEventListener<K extends keyof HTMLSwirlBoxElementEventMap>(type: K, listener: (this: HTMLSwirlBoxElement, ev: SwirlBoxCustomEvent<HTMLSwirlBoxElementEventMap[K]>) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof HTMLSwirlBoxElementEventMap>(type: K, listener: (this: HTMLSwirlBoxElement, ev: SwirlBoxCustomEvent<HTMLSwirlBoxElementEventMap[K]>) => any, options?: boolean | EventListenerOptions): void;
removeEventListener<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
removeEventListener<K extends keyof HTMLElementEventMap>(type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
removeEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | EventListenerOptions): void;
}
var HTMLSwirlBoxElement: {
prototype: HTMLSwirlBoxElement;
Expand Down Expand Up @@ -6019,6 +6034,7 @@ declare namespace LocalJSX {
"maxWidth"?: string;
"minHeight"?: string;
"minWidth"?: string;
"onComponentLoad"?: (event: SwirlBoxCustomEvent<void>) => void;
"overflow"?: SwirlBoxOverflow;
"padding"?: SwirlBoxPadding;
"paddingBlockEnd"?: SwirlBoxPadding;
Expand Down
2 changes: 1 addition & 1 deletion packages/swirl-components/src/components/swirl-resource-list/swirl-resource-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ export class SwirlResourceList {
) {
event.preventDefault();
this.stopDrag(this.dragging);
} else if (Boolean(this.controllingElement)) {
} else if (Boolean(this.controllingElement) && event.code === "Enter") {
const item = this.items[this.focusedIndex];

if (!Boolean(item) || !item.isConnected) {
Expand Down
Loading