Update menu item functionality #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Sqrrl
reviewed
Jan 30, 2025
| @@ -36,6 +36,7 @@ SwirlActionListItem.args = { | |||
| badge: "Badge", | |||
| description: "Description of the action list item", | |||
| icon: `<swirl-icon-mention></swirl-icon-mention>`, | |||
| iconBadge: `<swirl-badge></swirl-badge>`, | |||
There was a problem hiding this comment.
nitpick: Should have a label.
| > | ||
| {showIconBadge && ( | ||
| <span | ||
| class="action-list-item__icon__badge" |
There was a problem hiding this comment.
suggestion: action-list-item__icon-badge
We usually only do one level of nesting in the __ selectors.
| @@ -42,4 +42,6 @@ export const SwirlOptionListItem = Template.bind({}); | |||
| SwirlOptionListItem.args = { | |||
| label: "Option List Item", | |||
| value: "Value", | |||
| icon: `<swirl-icon-mention></swirl-icon-mention>`, | |||
| iconBadge: `<swirl-badge></swirl-badge>`, | |||
There was a problem hiding this comment.
nitpick: Should have a label.
There was a problem hiding this comment.
added a label
packages/swirl-components/src/components/swirl-menu/swirl-menu.tsx
Outdated
Show resolved
Hide resolved
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-929.westeurope.3.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-929.westeurope.3.azurestaticapps.net |
Sqrrl
approved these changes
Jan 30, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Review Checklist
General
For new or updated components
https://swirl-storybook.flip-app.dev/?path=/docs/contributions-merge-publish--page