HTTP-122 Add lookup retries #129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzegorz8
force-pushed
the
feature/122-lookup-retry
branch
from
271f382
to
65f49b3
Compare
2 tasks
grzegorz8
commented
Oct 16, 2024
| | gid.connector.http.lookup.error.code | optional | List of HTTP status codes that should be treated as errors by HTTP Source, separated with comma. | | ||
| | gid.connector.http.lookup.error.code.exclude | optional | List of HTTP status codes that should be excluded from the `gid.connector.http.lookup.error.code` list, separated with comma. | | ||
| | lookup.retry-strategy.type | optional | Defines the retry strategy to use in case of lookup failures. Accepted values are: `none` (default), `fixed-delay` and `exponential-delay`. | | ||
| | lookup.retry-strategy.fixed-delay.attempts | optional | The number of times that connector retries lookup execution before connector returns empty result. | |
There was a problem hiding this comment.
returns empty result
In current implementation, an empty result is returned if error status code is returned or when exception is thrown. To be honest I'm strongly against such approach. Errors should not be suppressed, at least by default. If error suppression is needed, user should have to configure it explicitly. WDYT?
grzegorz8
commented
Oct 16, 2024
| ConfigOptions.key("lookup.retry-strategy.fixed-delay.attempts") | ||
| .intType() | ||
| .defaultValue(3) | ||
| .withDescription("The number of times that the connector retires request" |
There was a problem hiding this comment.
typos: retires and emtpy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces lookup retires. Retry mechanism in Sink will be implemented in a separate PR.
User can define for which HTTP status codes lookup request should be retried (
source.lookup.error.retryable.codeandsource.lookup.error.retryable.code.exclude), and for which not (source.lookup.error.non-retryable.codeandsource.lookup.error.non-retryable.code.exclude). User can select one of three retry strategies (lookup.retry-strategy.type):none,fixed-delayorexponential-delay.Resolves
HTTP-122PR Checklist