-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add explicit credentials to AzureMLAssetDataset #161
Draft
AlexandreOuellet
wants to merge
12
commits into
getindata:develop
Choose a base branch
from
AlexandreOuellet:bugfix/AzureMLAssetDataset_credentials
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7df60e8
add explicit credentials to AzureMLAssetDataset
AlexandreOuellet 84774af
keep it compatible with previous, explicit after_catalog_created cred…
AlexandreOuellet 922848b
remove checks for catalog list, and use catalog.__contains__() instead
AlexandreOuellet 6e0fbaa
ensure AzurePipelineRunner handles dataset_factory
AlexandreOuellet 647b3a9
add error log to help debug issue with AzureMLAssetDataset path not b…
AlexandreOuellet 0c4db8f
add more error log for debugging asset_dataset.py
AlexandreOuellet 397b83f
revert back generator implementation
AlexandreOuellet bb334ee
revert back log error for debuging
AlexandreOuellet 91f25a3
add handling of all inputs, and not only those registered in data cat…
AlexandreOuellet 1ad46a1
revert back changes from runner.py
AlexandreOuellet fe9d343
Delete asf
AlexandreOuellet 6a985b2
remove azure_config from hook's self, as it is no longer needed
AlexandreOuellet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where the main difference happens. Instead of looping over the catalog, we loop over the pipeline's input, and then verify within the catalog if we have that input. That way, it gives a chance for the dataset factories to be instantiated, and they are then handled as usual (call as_remote(), etc...)