Skip to content

Commit

Permalink
Merge pull request #20 from getindata/fix/custom_role_logic
Browse files Browse the repository at this point in the history
fix: Create custom role logic
  • Loading branch information
dgniewek authored Jul 31, 2024
2 parents b12633e + 3c70b20 commit 154a7d4
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ repos:
args: ["."]

- repo: https://github.com/bridgecrewio/checkov.git
rev: "3.2.213" # Get the latest from: https://github.com/bridgecrewio/checkov/releases
rev: "3.2.216" # Get the latest from: https://github.com/bridgecrewio/checkov/releases
hooks:
- id: checkov
args: [--skip-check, "CKV_TF_1"] # Terraform module sources do not use a git url with a commit hash revision
Expand Down
13 changes: 0 additions & 13 deletions .tflint.hcl
Original file line number Diff line number Diff line change
@@ -1,16 +1,3 @@
config {
ignore_module = {
"Invicton-Labs/deepmerge/null" = true
}
}

plugin "terraform" {
enabled = true
version = "0.5.0"
source = "github.com/terraform-linters/tflint-ruleset-terraform"
preset = "all"
}

rule "terraform_standard_module_structure" {
enabled = false # Fails on context.tf
}
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ module "snowflake_custom_role" {

name = each.key
attributes = ["WHS", one(snowflake_warehouse.this[*].name)]
enabled = local.create_default_roles && lookup(each.value, "enabled", true)
enabled = lookup(each.value, "enabled", true)
descriptor_name = lookup(each.value, "descriptor_name", "snowflake-role")

role_ownership_grant = lookup(each.value, "role_ownership_grant", "SYSADMIN")
Expand Down

0 comments on commit 154a7d4

Please sign in to comment.