Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly syndicate to configured targets #668

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

paulrobertlloyd
Copy link
Collaborator

Fixes an issue where the syndication endpoint was looping over all configured syndication targets and comparing their URLs to that provided in a mp-syndicate-to property, but without accounting for the fact that this value could be an array.

This lead to all syndication targets being syndicated against, even if not selected by the author when creating a post.

Now we loop through each value in mp-syndicate-to, check that a target for that value has been configured, and that the post has not already been syndicated to that URL.

Hopefully this makes syndication a little less buggier, but this part of the application remains more challenging than it perhaps should be.

@paulrobertlloyd paulrobertlloyd added the plugin-endpoint Endpoint plug-in label Nov 3, 2023
@paulrobertlloyd paulrobertlloyd added this to the v1.0 milestone Nov 3, 2023
@paulrobertlloyd paulrobertlloyd merged commit bc1939a into main Nov 3, 2023
1 check passed
@paulrobertlloyd paulrobertlloyd deleted the mp-syndicate-array branch November 3, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin-endpoint Endpoint plug-in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant