Correctly syndicate to configured targets #668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the syndication endpoint was looping over all configured syndication targets and comparing their URLs to that provided in a
mp-syndicate-to
property, but without accounting for the fact that this value could be an array.This lead to all syndication targets being syndicated against, even if not selected by the author when creating a post.
Now we loop through each value in
mp-syndicate-to
, check that a target for that value has been configured, and that the post has not already been syndicated to that URL.Hopefully this makes syndication a little less buggier, but this part of the application remains more challenging than it perhaps should be.