Replace Stimulus with web components #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrobertlloyd
force-pushed
the
replace-stimulus-with-web-components
branch
from
73c662e to
366043b
Compare
paulrobertlloyd
changed the title
paulrobertlloyd
force-pushed
the
replace-stimulus-with-web-components
branch
from
366043b to
ce0c967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading a little about web components, it seems Stimulus is adding little that can’t be done natively in the browser using custom elements.
This PR replaces all usage of Stimulus with custom elements. The impact of this change is slightly improved code coverage (tiny amount) and massively reduced JavaScript asset size, reducing the overall bundle from ~26 kB to ~10 kB.