Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jekyll and Hugo post templates to accept unknown properties #680

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

paulrobertlloyd
Copy link
Collaborator

Currently, the provided preset plugins dictate the post properties that will be output in a post’s front matter. And yet, we allow users to add different post types that, down the line, could output different properties.

This PR updates the 2 preset plugins, adjusting only the properties that need adjusting, and thus allowing unknown properties to be output. This also means these presets don’t need updating every time there is a change to the posts and properties produced by the/a Micropub plugin.

Also, this PR prevents mp-* properties from being sent to the postTemplate() function; these are only intended for sending commands to Micropub servers, and should not be used in posts.

@paulrobertlloyd paulrobertlloyd added enhancement New feature or request code quality Making things easier to understand plugin-preset Preset plug-in labels Jan 10, 2024
@paulrobertlloyd paulrobertlloyd added this to the v1.0 milestone Jan 10, 2024
@paulrobertlloyd paulrobertlloyd merged commit f7ccce9 into main Jan 10, 2024
1 check passed
@paulrobertlloyd paulrobertlloyd deleted the feat/preset-properties branch January 10, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Making things easier to understand enhancement New feature or request plugin-preset Preset plug-in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant