Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty name property in post type discovery #757

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Ignore empty name property in post type discovery #757

merged 1 commit into from
Aug 20, 2024

Conversation

paulrobertlloyd
Copy link
Collaborator

Fixes #756.

Rather than check for the presence of the name property, check for the presence of a value assigned to name.

@paulrobertlloyd paulrobertlloyd added bug Something isn't working plugin-endpoint Endpoint plug-in labels Aug 20, 2024
@paulrobertlloyd paulrobertlloyd added this to the v1.0 milestone Aug 20, 2024
@paulrobertlloyd paulrobertlloyd merged commit 02baa2b into main Aug 20, 2024
1 check passed
@paulrobertlloyd paulrobertlloyd deleted the fix/756-ptd-ignore-empty-properties branch August 20, 2024 22:45
@paulrobertlloyd
Copy link
Collaborator Author

@gerwitz This should fix the issue you reported regarding notes being discovered as articles. It’ll be in beta-18, which I’ll try and ship in the next week (I’d like to incorporate some of @jackdbd’s contributions as part of the next release too).

@gerwitz
Copy link

gerwitz commented Aug 21, 2024

Thanks! I hadn't even gotten to creating an issue and you've already resolved. 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working plugin-endpoint Endpoint plug-in
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Empty properties are not ignored when performing post type discovery
2 participants
@paulrobertlloyd @gerwitz