Update errcheck to latest from kisielk/master. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle embedded nil interfaces.
Detect the file beginning by using `pass.Fset.File(f.Pos())` instead of assuming that `f.Pos()` is always the beginning of the file. `f.Pos()` is not the beginning of the file when there is for instance a comment before the package, which can lead to wrong reportings of the actual error position. Signed-off-by: Roman Mohr <[email protected]>
Calculate correct position with comments before the package keyword
…ielk#220) Noticed that some useful flags were not documented in the README.md. I've added the these in what I think are the relevant sections. I did a minimal explanation of the flags, but can expand on them. I erred on the side of not expanding on -ignoregenerated for example because the regex might change in the future, and documentation tends to be a forgotten update...
Constants LoadSyntax and LoadAllSyntax is deprecated. See https://pkg.go.dev/golang.org/x/[email protected]/go/packages#pkg-constants.
Correct typos in comments and doc
Fix errcheck issues in tests
Directly specify the needed fields when loading packages
This allows wrapping errcheck.Analyzer with nolint.Wrap to silence diagnostics with //nolint:errcheck comments. Link: https://github.com/kyoh86/nolint Signed-off-by: Robin Jarry <[email protected]>
* mod: Use latest /x/tools, use Go 1.18
Upgrades to the latest release of /x/tools and friends.
This is necessary to fix errors during `go test` similar to:
This fixes errors like this: internal error: package "bytes" without types was imported from "command-line-arguments"
Supersedes kisielk#231
* ci: Test against Go 1.18-1.20
Switch CI to only test against Go 1.18 to 1.20.
Per the Go support policy, only 1.19 and 1.20 are currently supported,
but I've left 1.18 in there to support stragglers.
To reduce duplication in the CI job, this also switches to a test matrix
instead of copy-pasting the steps between each job.
* Update dependencies to work with Go 1.22 * Add go 1.22 to the build matrix in github actions --------- Co-authored-by: Addie Bendory <[email protected]>
* chore(*): fix typos && simplify some test code * chore(typo): fix typo
HeinKalido
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main
errcheckrepo has received some changes to improve compatibility with Go v1.22, which should probably be merged into Kalido's fork. This also has the benefit of resolving a security alert by Dependabot.