Add end to end tests for core/event processors #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tftshubham
approved these changes
Jun 26, 2023
rjacobs31
reviewed
Jun 26, 2023
| Exclusive: false, | ||
| RoutingKey: "path", | ||
| Args: map[string]interface{}{ | ||
| "x-queue-type": "quorum", |
There was a problem hiding this comment.
Maybe we want this as part of the QueueSettings type? It's easier to specify if you don't need to remember that specific key just to make it work.
There was a problem hiding this comment.
The interface reflects the rabbit API. We could change it, not sure that is better.
We should just really write a helper for this so we don't have it replicated so many times (and then no need to know that this is needed).
There was a problem hiding this comment.
Not really, though. Take a look at exchange.go:322. There's precedent for having fields which don't map directly.
|
Also, the tests have been blocked for almost 2 h now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds end to end tests, using the libraries like core and match would.
This also adds some additional guarantees to the stopping of event processors (something we don't really use, but is important in tests).
Calling close will wait until all the event handlers are done before returning.
This also adds an example of how quorum queues would work in match.