-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4] PHP 8.4 support #6811
base: develop-minor
Are you sure you want to change the base?
[v4] PHP 8.4 support #6811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of the CS fixes will create merge conflicts with v5. E.g. in v5 we have replaced the something|null $param = null
params with something|null $param
and made some fixes to docblocks where CS fixer now again wreaks havoc.
If we merge this as is to ensure PHP 8.4 compatibility in v4, we should probably not continue to merge back v4 changes into the v5 branch, otherwise it will be a merge conflict hell. Alternative could be to backport the CS changes manually from v5.
@lukasbestle We made nullable parameters non-optional? This got created as Basti mentioned the user demand for 8.4 support in v4 as well. I think we'll need to tackle the merge conflict once. I think it'll be not too bad (as we've merged regularly, merging into |
Not in general, but in some Looking back, it would have been better to make those changes in v4 and not v5. But now it's like it is. |
If we merge In terms of making those changes for v4 as well of course not. But maybe that's ok that v4 doesn't get those enhancements but just most basic 8.4 support. |
Changelog
Enhancements
Ready?
For review team