Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start up sequence callback #1070

Merged
merged 33 commits into from
Jun 10, 2024
Merged

Start up sequence callback #1070

merged 33 commits into from
Jun 10, 2024

Conversation

jigar-f
Copy link
Contributor

@jigar-f jigar-f commented May 8, 2024

No description provided.

@jigar-f jigar-f self-assigned this May 9, 2024
@jigar-f jigar-f requested a review from atavism May 22, 2024 10:43
@jigar-f jigar-f marked this pull request as ready for review May 22, 2024 10:43
@jigar-f
Copy link
Contributor Author

jigar-f commented May 23, 2024

@atavism Go ahead and review this as well, If all is okay merge this and then put out new build.

@atavism
Copy link
Contributor

atavism commented May 24, 2024

Taking a look, @jigar-f!

go.mod Outdated Show resolved Hide resolved
@atavism
Copy link
Contributor

atavism commented May 28, 2024

This is how the VPN switch looks for me on desktop with these changes. Just confirming we want to change the appearance like this?

Before:

image

After:

Screenshot 2024-05-27 at 4 57 21 PM

lib/app.dart Show resolved Hide resolved
lib/vpn/vpn_tab.dart Outdated Show resolved Hide resolved
Copy link
Contributor

@atavism atavism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments but otherwise LGTM

@jigar-f
Copy link
Contributor Author

jigar-f commented May 28, 2024

This is how the VPN switch looks for me on desktop with these changes. Just confirming we want to change the appearance like this?

I had to change the switch package due to lack of customization else the UI same.
cc @Derekf5 Do you mind checking this UI and letting me know, if these changes look good?

@atavism
Copy link
Contributor

atavism commented Jun 5, 2024

@Derekf5 @jigar-f Are we fine changing the appearance of the VPN switch in the desktop app to look like this? (IMO, it's a little too big). I think that's the main holdup getting this one merged.

image

@jigar-f
Copy link
Contributor Author

jigar-f commented Jun 6, 2024

I think Derekf approved these changes last week.

@jigar-f
Copy link
Contributor Author

jigar-f commented Jun 6, 2024

Also, @atavism We need to merge flashlight PR before this, I just asked reflog for review on flashlight pr, if all okay we can merge that

@atavism
Copy link
Contributor

atavism commented Jun 6, 2024

I think Derekf approved these changes last week.

Cool, thanks for confirming!

@atavism
Copy link
Contributor

atavism commented Jun 10, 2024

@jigar-f getlantern/flashlight#1387 has been merged and this PR has been updated with the latest changes. OK to merge this now?

@jigar-f
Copy link
Contributor Author

jigar-f commented Jun 10, 2024

Cool, let's merge it.

@atavism atavism merged commit b397e87 into main Jun 10, 2024
2 checks passed
@atavism atavism deleted the jigar/init-callback branch June 10, 2024 12:59
@atavism
Copy link
Contributor

atavism commented Jun 10, 2024

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants