-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intl 0.19, remove greenrobot.eventbus to support latest version of Flutter #1102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!, Just two comments.
@atavism The Only issue with upgrading to Flutter is this crash on android. any version less than 14 it crashes. Do you mind testing this In 11,12 or 13 and see if you are getting crash? |
@jigar-f Thanks! I didn't realize upgrading Flutter causes a crash on earlier versions of Android. Taking a look now |
Ok, the app is crashing for me testing with a Samsung Galaxy S9 running Android 9:
|
It's related to this issue here: pichillilorenzo/flutter_inappwebview#2139 |
Ok, removing the |
thanks, @atavism for looking into this, I will test this shortly. |
@atavism Can we please add these proguard rules as well? |
Done c44fb24 |
…hared flow (#1103) * Remove use of org.greenrobot.eventbus * Remove use of org.greenrobot.eventbus * Add EventHandler * Update how we subscribe to app events * Update how we subscribe to app events * Update how we subscribe to app events * clean-ups * handle LocaleEvent * Add proguard rules for J2ObjC Annotations
No description provided.