update http.RoundTripper used by Auth client #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atavism
commented
Dec 4, 2024
internalsdk/auth/auth.go
Outdated
| rc := webclient.NewRESTClient(&webclient.Opts{ | ||
| BaseURL: baseURL, | ||
| OnBeforeRequest: func(client *resty.Client, req *http.Request) error { | ||
| prepareUserRequest(req, userConfig()) | ||
| return nil | ||
| }, | ||
| HttpClient: httpClient, | ||
| HttpClient: &http.Client{ | ||
| Transport: serialTransport{chained, frt}, |
There was a problem hiding this comment.
This updates the auth client to use an http.Client that first attempts to connect via chained proxies and then falls back to using domain fronting with the custom name above (@jigar-f @hwh33 I'm not sure if we can just use proxied.ChainedThenFronted() here?).
Please let me know if this is correct otherwise feel free to change it to the one we should be using
There was a problem hiding this comment.
I remember some work needs to be done on auth API access not sure if that was done or not, Let's wait for @hwh33 on this.
There was a problem hiding this comment.
Yeah I would just use ChainedThenFronted
myleshorton
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.