Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads hotfix #910

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Ads hotfix #910

merged 8 commits into from
Sep 13, 2023

Conversation

jigar-f
Copy link
Contributor

@jigar-f jigar-f commented Sep 12, 2023

Here's the PR for the ads fix, addressing multiple issues.

  • We've now adopted the Subscription pattern for the Ads feature.
  • Note: If the secret isn't found during the build, the script will fail.

However, there's one persistent problem: Google ads work in the debug build but not in the release. I suspect we might need to contact support. I'll take care of that tomorrow.

@atavism
Copy link
Contributor

atavism commented Sep 12, 2023

It looks like building a release in CI is failing:

mkdir -p ./android/app/libs && \
cp liblantern-all.aar ./android/app/libs/liblantern-all.aar
/bin/sh: 1: [[: not found
trap: ERR: bad trap
make[1]: *** [Makefile:346: lantern-installer.apk] Error 1
make[1]: Leaving directory '/home/runner/work/android-lantern/android-lantern'
make: *** [Makefile:392: package-android] Error 2
Error: Process completed with exit code 2.

Copy link
Contributor

@atavism atavism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the CI issue publishing releases, this LGTM!

@jigar-f
Copy link
Contributor Author

jigar-f commented Sep 13, 2023

@atavism I am working on changes to the release flow, Will push changes shortly

@jigar-f
Copy link
Contributor Author

jigar-f commented Sep 13, 2023

@atavism Getting some kind of API issue, Do you mind taking a look at this?

@oxtoacart oxtoacart merged commit 70c24d7 into main Sep 13, 2023
3 of 5 checks passed
@oxtoacart oxtoacart deleted the ads-hotfix branch September 13, 2023 14:15
@jigar-f jigar-f restored the ads-hotfix branch September 14, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants