Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of Datadog RUM #925

Merged
merged 9 commits into from
Oct 10, 2023
Merged

Remove use of Datadog RUM #925

merged 9 commits into from
Oct 10, 2023

Conversation

atavism
Copy link
Contributor

@atavism atavism commented Oct 5, 2023

@atavism atavism changed the title Remove datadog Remove use of Datadog Oct 5, 2023
@atavism atavism requested a review from oxtoacart October 5, 2023 19:32
@atavism atavism changed the title Remove use of Datadog Remove use of Datadog RUM Oct 6, 2023
@atavism atavism requested a review from jigar-f October 6, 2023 15:49
Copy link
Contributor

@jigar-f jigar-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atavism If we are removing datadog, Can you also remove datadog folder on kotlin

@atavism
Copy link
Contributor Author

atavism commented Oct 9, 2023

@atavism If we are removing datadog, Can you also remove datadog folder on kotlin

Done

@jigar-f
Copy link
Contributor

jigar-f commented Oct 10, 2023

@atavism Can we also remove this from Gradle

def ddApplicationID() {
    def value = project.getProperties().get("ddApplicationID")
    if (value == null || !value?.trim()) {
        return "\"\""
    }
    return String.format("\"%s\"", value)
}

def ddClientToken() {
    def value = project.getProperties().get("ddClientToken")
    if (value == null || !value?.trim()) {
        return "\"\""
    }
    return String.format("\"%s\"", value)
}

@atavism
Copy link
Contributor Author

atavism commented Oct 10, 2023

Can we also remove this from Gradle ...

@jigar-f, done!

@atavism atavism merged commit 5ff6078 into main Oct 10, 2023
5 checks passed
@atavism atavism deleted the atavism/remove-datadog branch October 10, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants