Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop migration #947

Closed
wants to merge 295 commits into from
Closed

Desktop migration #947

wants to merge 295 commits into from

Conversation

atavism
Copy link
Contributor

@atavism atavism commented Nov 9, 2023 •
edited
Loading

To run the app:

  • go build -buildmode=c-shared -o desktop/liblantern.dylib desktop/lib.go
  • flutter run -d macOS

@atavism atavism marked this pull request as draft November 9, 2023 05:24
@atavism
Copy link
Contributor Author

atavism commented Nov 30, 2023 •
edited
Loading

Building the app for Windows is failing because of the following:

D:\a\lantern-client\lantern-client\windows\runner\flutter_window.cpp(37,24): error C2039: 'ForceRedraw': is not a member of 'flutter::FlutterViewController' [D:\a\lantern-client\lantern-client\build\windows\runner\androidlantern.vcxproj]
Building Windows application...                                 
Building Windows application...                                   233.5s
Build process failed.

@atavism
Copy link
Contributor Author

atavism commented Jan 4, 2024

I'm not sure why we are getting this error notarizing the darwin installer:

OK, this is finally fixed!

atavism and others added 22 commits January 4, 2024 20:46
@atavism
update flashlight
19fa5a6
@atavism
Update macos release entitlements
2bcef1b
@atavism
Update macos release entitlements
3a9a3ce
@atavism
sign liblantern.dylib in frameworks directory
8aec7c0
@atavism
sign liblantern.dylib in frameworks directory
1579a89
@atavism
sign liblantern.dylib in frameworks directory
c971f09
@atavism
sign liblantern.dylib in frameworks directory
28b432c
@atavism
notarize darwin installer again
1940ab5
@reflog
Update go.yml
771a1ac
@atavism
revert recent Makefile changes, attempt to notarize installer again
36950b5
@atavism
Update notarize-darwin.py
7c5af52
@atavism
Update notarize-darwin
ba2adaa
@atavism
Update notarize-darwin
4f5aca3
@atavism
Use tray manager instead of system tray (#977)
5a6bc5e 
* use tray manager instead of system tray

* Add menu options

* Add show menu option
@dependabot
Bump jinja2 from 3.0.3 to 3.1.3 in /scripts/screenshot_generation_ass…
5704212 
…ets (#972)

Bumps [jinja2](https://github.com/pallets/jinja) from 3.0.3 to 3.1.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@3.0.3...3.1.3)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump fonttools in /scripts/screenshot_generation_assets (#971)
1573d90 
Bumps [fonttools](https://github.com/fonttools/fonttools) from 4.28.5 to 4.43.0.
- [Release notes](https://github.com/fonttools/fonttools/releases)
- [Changelog](https://github.com/fonttools/fonttools/blob/main/NEWS.rst)
- [Commits](fonttools/fonttools@4.28.5...4.43.0)

---
updated-dependencies:
- dependency-name: fonttools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@atavism
update notarize-darwin.py
40a8ef2
@atavism
fix permissions
dc4cb88
@atavism
Merge remote-tracking branch 'origin/main' into atavism/ios-migrate-d…
662119e 
…esktop
@atavism
Update flashlight, temporarily disable notarization
f54cde6
@atavism
sign liblantern.dylib in Frameworks only
276b088
@atavism
Makefile updates
a6b3fde
@atavism
Copy link
Contributor Author

atavism commented Feb 2, 2024

Closing in favor of #984

@atavism atavism closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atavism @myleshorton @reflog @jay-418