-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle cookie based login #269
Draft
RohitR311
wants to merge
16
commits into
develop
Choose a base branch
from
cookie-store
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+398
−39
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
649be48
feat: add export type for RegexableString
RohitR311 1334b5c
feat: add cookie_storage field in robot model
RohitR311 8696827
feat: add get and put route for cookie storage
RohitR311 05e583f
feat: add cookie storage post login logic
RohitR311 b19a0da
feat: rm logic to rm from workflow
RohitR311 08fb841
feat: add logic to fetch and set cookies during interpretation
RohitR311 2619da3
feat: add robotId for InterpretRecording
RohitR311 7ffbceb
feat: add robotId for InterpretRecording
RohitR311 cfce4a2
feat: add radio input field to check for login
RohitR311 6756b41
feat: add isLogin bool to check for login
RohitR311 a0fc8cf
feat: pass isLogin on robot creation
RohitR311 3f88860
feat: pass isLogin false on robot duplication
RohitR311 798c49e
feat: add isLogin field in robots model
RohitR311 0fced6b
feat: pass isLogin as payload entry in saveRecording
RohitR311 ea7d4e8
feat: fetch login status for a robot id
RohitR311 46c9343
feat: add route to get login status
RohitR311 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Commenting out regex initialization could break URL pattern matching
The verification reveals that regex functionality is actively used in the codebase:
$regex
is part of the workflow type definition (RegexableString
)$regex
are generated inGenerator.ts
interpret.ts
for URL validation with.test()
Commenting out the regex initialization in
preprocessor.ts
will prevent the conversion of string patterns toRegExp
objects, which will cause runtime errors when the code attempts to use.test()
on unconverted regex strings.🔗 Analysis chain
Verify the impact of removing regex initialization.
The commented-out code block handles regex parameter initialization. This change could affect workflow processing if regex functionality is still expected elsewhere in the codebase.
Let me gather more context about the regex initialization and its usage.
Let me check one more aspect to understand how URLs with regex patterns are processed in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 2501
Script:
Length of output: 376
Script:
Length of output: 1016