submissionXmlToFieldStream: handle stream end properly #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 30, 2024 08:24
Previously if poorly-structured or undefined/null XML was passed to this function, it would hang.
alxndrsn
pushed a commit
to alxndrsn/odk-central-backend
that referenced
this pull request
Oct 30, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
2 tasks
This comment was marked as resolved.
This comment was marked as resolved.
matthew-white
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if poorly-structured or undefined/null XML was passed to this function, the iterator this function returns would hang.