Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: handle 307 redirects #716

Closed
wants to merge 1 commit into from
Closed

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Sep 19, 2024

No description provided.

service.dockerfile Outdated Show resolved Hide resolved
@alxndrsn alxndrsn force-pushed the s3-redirects branch 2 times, most recently from 30162cc to ec65b68 Compare September 20, 2024 06:10
@alxndrsn alxndrsn force-pushed the s3-redirects branch 2 times, most recently from c61fbe7 to 1b5337d Compare September 20, 2024 06:24
@alxndrsn alxndrsn marked this pull request as ready for review September 20, 2024 06:25
@alxndrsn alxndrsn requested a review from lognaturel September 20, 2024 06:25
@alxndrsn alxndrsn mentioned this pull request Sep 20, 2024
5 tasks
@lognaturel
Copy link
Member

lognaturel commented Sep 20, 2024

Capturing some quick initial thoughts that I will chew on for a bit:

  • the behavior is nice. It serves the primary goal of clients not needing to follow redirects. It doesn't fully hide the storage used because some headers may still come through from the provider but it does keep things like the bucket name private (though that's not actually private info)
  • there's non-trivial overhead (see below)
  • it would be nice for the DNS server to be configurable
  • maybe the whole behavior could/should be opt-in

I did a few rounds of looking at request time and got consistent results that look like about 200ms extra than without which is itself already more than when the blobs were in the db (these relative values depend most on speed of application server and speed of db server; these are meaningful because they're Cloud infrastructure):

Without:
Screenshot 2024-09-20 at 12 51 21 PM

With:
Screenshot 2024-09-20 at 12 55 25 PM

From db:
Screenshot 2024-09-20 at 1 02 23 PM

@ktuite ktuite added backend Requires a change to the API server ops Docker, nginx, ops to deploy Central labels Sep 26, 2024
@alxndrsn
Copy link
Contributor Author

alxndrsn commented Oct 3, 2024

Closing after discussion with @lognaturel.

@alxndrsn alxndrsn closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Requires a change to the API server ops Docker, nginx, ops to deploy Central
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants