Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Central version to client-config.json #848

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

matthew-white
Copy link
Member

@matthew-white matthew-white commented Dec 16, 2024

This PR completes part of #849 and goes along with getodk/central-frontend#1099. The goal of this PR is to add the Central version from version.txt to client-config.json so that Frontend has easy access to it.

What has been done to verify that this works as intended?

Nothing yet. Currently, a test is failing, so I plan to patch existing tests. Once this PR is on staging, we can verify it together with getodk/central-frontend#1099.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

getodk/central-frontend#1099 is set up so that nothing breaks if centralVersion is missing in client-config.json.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white marked this pull request as draft December 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant