Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove theme from settings description and access control #6549

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove theme from settings description and access control #6549

wants to merge 2 commits into from
+10 −1

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Dec 12, 2024 •
edited
Loading

Closes #6544, #6551

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg marked this pull request as ready for review December 12, 2024 16:01
@seadowg seadowg requested a review from grzesiek2010 December 12, 2024 16:01
@seadowg seadowg marked this pull request as draft December 16, 2024 11:32
@seadowg seadowg removed the request for review from grzesiek2010 December 16, 2024 11:32
@seadowg seadowg marked this pull request as ready for review December 16, 2024 14:00
@seadowg seadowg changed the title Remove theme from settings description Remove theme from settings description and access control Dec 16, 2024
@seadowg seadowg requested a review from grzesiek2010 December 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzesiek2010 grzesiek2010 Awaiting requested review from grzesiek2010

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"theme" in description of "User interface"
1 participant
@seadowg