Merge pull request #355 from SaumiaSinghal/Issue#354

Closes #354: Added CheckStyle rule to check for multiple blank lines between field declarations

config/checkstyle.xml

@@ -96,6 +96,7 @@
         <module name="ModifierOrder" />
         <module name="EmptyLineSeparator">
             <property name="allowNoEmptyLineBetweenFields" value="true" />
+            <property name="allowMultipleEmptyLines" value="false"/>
         </module>
         <module name="SeparatorWrap">
             <property name="id" value="SeparatorWrapDot" />

skunkworks_crow/src/main/java/org/odk/collect/android/dao/FormsDao.java

@@ -29,7 +29,6 @@
 import java.util.ArrayList;
 import java.util.List;
 
-
 public class FormsDao {
 
     private Context context;

skunkworks_crow/src/main/java/org/odk/share/dao/InstanceMapDao.java

@@ -12,7 +12,6 @@
 import static org.odk.share.dto.InstanceMap.INSTANCE_UUID;
 import static org.odk.share.provider.InstanceMapProvider.CONTENT_URI;
 
-
 /**
  * Created by laksh on 8/2/2018.
  */

skunkworks_crow/src/main/java/org/odk/share/injection/config/AppModule.java

@@ -1,6 +1,5 @@
 package org.odk.share.injection.config;
 
-
 import android.app.Application;
 import android.content.Context;
 

skunkworks_crow/src/main/java/org/odk/share/injection/config/scopes/PerApplication.java

@@ -1,6 +1,5 @@
 package org.odk.share.injection.config.scopes;
 
-
 import java.lang.annotation.Documented;
 import java.lang.annotation.Retention;
 

skunkworks_crow/src/main/java/org/odk/share/rx/RxEventBus.java

@@ -1,6 +1,5 @@
 package org.odk.share.rx;
 
-
 import com.jakewharton.rxrelay2.PublishRelay;
 import com.jakewharton.rxrelay2.Relay;
 
@@ -35,7 +34,6 @@ public <T> Observable<T> register(@NonNull Class<T> eventClass) {
                 .map(obj -> (T) obj);
     }
 
-
     /**
      * Sends an event to all the observers who have registered to receive the event type.
      *

skunkworks_crow/src/main/java/org/odk/share/rx/schedulers/BaseSchedulerProvider.java

@@ -2,7 +2,6 @@
 
 import io.reactivex.Scheduler;
 
-
 /**
  * Allow providing different types of {@link Scheduler}s.
  */

skunkworks_crow/src/main/java/org/odk/share/services/HotspotService.java

@@ -43,7 +43,6 @@
 
 import io.reactivex.disposables.CompositeDisposable;
 
-
 public class HotspotService extends Service {
 
     public static final String ACTION_START = "hotspot_start";

skunkworks_crow/src/main/java/org/odk/share/utilities/ArrayUtils.java

@@ -1,6 +1,5 @@
 package org.odk.share.utilities;
 
-
 public class ArrayUtils {
 
     /**
@@ -13,7 +12,6 @@ public class ArrayUtils {
      */
     private static final long[] EMPTY_LONG_ARRAY = new long[0];
 
-
     private ArrayUtils() {
 
     }

skunkworks_crow/src/main/java/org/odk/share/utilities/PermissionUtils.java

@@ -1,6 +1,5 @@
 package org.odk.share.utilities;
 
-
 import android.app.Activity;
 import android.content.Context;
 import android.content.DialogInterface;

skunkworks_crow/src/main/java/org/odk/share/views/ui/about/AboutItem.java

@@ -1,6 +1,5 @@
 package org.odk.share.views.ui.about;
 
-
 import androidx.annotation.DrawableRes;
 import androidx.annotation.StringRes;
 

skunkworks_crow/src/main/java/org/odk/share/views/ui/bluetooth/BluetoothListAdapter.java

@@ -23,7 +23,6 @@
 import static android.bluetooth.BluetoothDevice.BOND_BONDED;
 import static android.bluetooth.BluetoothDevice.BOND_NONE;
 
-
 /**
  * BluetoothListAdapter: {@link RecyclerView.Adapter} for {@link BluetoothDevice}.
  *

skunkworks_crow/src/main/java/org/odk/share/views/ui/bluetooth/BtReceiverActivity.java

@@ -1,6 +1,5 @@
 package org.odk.share.views.ui.bluetooth;
 
-
 import android.Manifest;
 import android.app.AlertDialog;
 import android.app.ProgressDialog;

skunkworks_crow/src/main/java/org/odk/share/views/ui/bluetooth/BtSenderActivity.java

@@ -1,6 +1,5 @@
 package org.odk.share.views.ui.bluetooth;
 
-
 import android.Manifest;
 import android.app.AlertDialog;
 import android.app.ProgressDialog;
@@ -55,7 +54,6 @@
 import static org.odk.share.views.ui.instance.fragment.ReviewedInstancesFragment.MODE;
 import static org.odk.share.views.ui.send.fragment.BlankFormsFragment.FORM_IDS;
 
-
 /**
  * Bluetooth sender activity.
  *
@@ -99,7 +97,6 @@ public class BtSenderActivity extends InjectableActivity {
     private long[] formIds;
     private int mode;
 
-
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);

skunkworks_crow/src/main/java/org/odk/share/views/ui/common/applist/AppListActivity.java

@@ -41,7 +41,6 @@
 
 import static org.odk.share.utilities.ApplicationConstants.SortingOrder.BY_NAME_ASC;
 
-
 public abstract class AppListActivity extends InjectableActivity {
 
     private static final String SELECTED_INSTANCES = "selectedInstances";

skunkworks_crow/src/main/java/org/odk/share/views/ui/common/basecursor/BaseCursorViewHolder.java

@@ -6,7 +6,6 @@
 
 import org.odk.share.views.listeners.ItemClickListener;
 
-
 public class BaseCursorViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {
 
     private ItemClickListener listener;

skunkworks_crow/src/main/java/org/odk/share/views/ui/common/basecursor/CursorRecyclerViewAdapter.java

@@ -9,7 +9,6 @@
 
 import org.odk.share.views.listeners.ItemClickListener;
 
-
 public abstract class CursorRecyclerViewAdapter<T extends BaseCursorViewHolder> extends RecyclerView.Adapter<T> {
 
     protected Context context;

skunkworks_crow/src/main/java/org/odk/share/views/ui/instance/InstancesList.java

@@ -94,7 +94,6 @@ public void onLoadFinished(@NonNull Loader<Cursor> loader, Cursor cursor) {
         }
     }
 
-
     @Override
     public void onLoaderReset(@NonNull Loader loader) {
     }

skunkworks_crow/src/main/java/org/odk/share/views/ui/instance/adapter/InstanceAdapter.java

@@ -104,8 +104,6 @@ public int getItemCount() {
         return !cursor.isClosed() ? cursor.getCount() : 0;
     }
 
-
-
     public Cursor getCursor() {
         return cursor;
     }

skunkworks_crow/src/main/java/org/odk/share/views/ui/main/FormListActivity.java

@@ -1,6 +1,5 @@
 package org.odk.share.views.ui.main;
 
-
 import org.odk.collect.android.provider.FormsProviderAPI;
 import org.odk.share.views.ui.common.applist.AppListActivity;
 

skunkworks_crow/src/main/java/org/odk/share/views/ui/main/MainActivity.java

@@ -84,7 +84,6 @@ public class MainActivity extends FormListActivity implements LoaderManager.Load
 
     private FormsAdapter formAdapter;
 
-
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);

skunkworks_crow/src/main/java/org/odk/share/views/ui/send/fragment/BlankFormsFragment.java

@@ -1,5 +1,3 @@
-
-
 package org.odk.share.views.ui.send.fragment;
 
 import android.content.Intent;
@@ -74,7 +72,6 @@ public class BlankFormsFragment extends FormListFragment implements LoaderManage
     private FormsAdapter formAdapter;
     private LinkedHashSet<Long> selectedForms;
 
-
     public BlankFormsFragment() {
     }
 
@@ -123,7 +120,6 @@ public void onLoadFinished(@NonNull Loader<Cursor> loader, Cursor cursor) {
         }
     }
 
-
     @Override
     public void onLoaderReset(@NonNull Loader loader) {
     }

skunkworks_crow/src/main/java/org/odk/share/views/ui/send/fragment/FilledFormsFragment.java

@@ -113,7 +113,6 @@ public void onLoadFinished(@NonNull Loader<Cursor> loader, Cursor cursor) {
         }
     }
 
-
     @Override
     public void onLoaderReset(@NonNull Loader loader) {
     }

skunkworks_crow/src/main/java/org/odk/share/views/ui/settings/SettingsActivity.java

@@ -29,7 +29,6 @@
 
 import org.odk.share.R;
 
-
 /**
  * Created by laksh on 5/27/2018.
  */

skunkworks_crow/src/test/java/org/odk/share/activities/AboutActivityTest.java

@@ -1,6 +1,5 @@
 package org.odk.share.activities;
 
-
 import android.content.Intent;
 import android.view.View;
 

skunkworks_crow/src/test/java/org/odk/share/activities/BtReceiverActivityTest.java

@@ -1,6 +1,5 @@
 package org.odk.share.activities;
 
-
 import android.bluetooth.BluetoothAdapter;
 import android.bluetooth.BluetoothDevice;
 import android.content.BroadcastReceiver;

skunkworks_crow/src/test/java/org/odk/share/activities/HpReceiverActivityTest.java

@@ -1,6 +1,5 @@
 package org.odk.share.activities;
 
-
 import androidx.appcompat.widget.Toolbar;
 
 import org.junit.Before;

skunkworks_crow/src/test/java/org/odk/share/activities/HpSenderActivityTest.java

@@ -1,6 +1,5 @@
 package org.odk.share.activities;
 
-
 import androidx.appcompat.widget.Toolbar;
 
 import org.junit.Before;

skunkworks_crow/src/test/java/org/odk/share/activities/MainActivityTest.java

@@ -1,6 +1,5 @@
 package org.odk.share.activities;
 
-
 import android.content.Intent;
 import android.content.SharedPreferences;
 import android.preference.PreferenceManager;

skunkworks_crow/src/test/java/org/odk/share/utilities/ArrayUtilsTest.java

@@ -1,6 +1,5 @@
 package org.odk.share.utilities;
 
-
 import org.junit.Test;
 
 import static org.junit.Assert.assertArrayEquals;