Allow CSV/TSV/Excel download from shared dashboards #7218
+60
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaecoli
reviewed
Nov 15, 2024
| @@ -27,8 +27,12 @@ function visualizationWidgetMenuOptions({ widget, canEditDashboard, onParameters | |||
| const canEditParameters = canEditDashboard && !isEmpty(invoke(widget, "query.getParametersDefs")); | |||
| const widgetQueryResult = widget.getQueryResult(); | |||
| const isQueryResultEmpty = !widgetQueryResult || !widgetQueryResult.isEmpty || widgetQueryResult.isEmpty(); | |||
|
|
|||
| const downloadLink = fileType => widgetQueryResult.getLink(widget.getQuery().id, fileType); | |||
| const parts = window.location.pathname.split('/').reverse() | |||
There was a problem hiding this comment.
These codes are unmaintainable and may not work in some browsers. I have mentioned this code before and it was rejected. If you want to do this function, I suggest rewriting a public page component to support it. It's my mind.
And i don't know parts[0].length === 40 meaning? i think it's unmaintaineable.
eradman
force-pushed
the
share-link-download
branch
from
f3fb796
to
b075cc9
Compare
- Always show dropdown menu - Append ?api_key for dashboards using the path /public/ - Compare api_key with dashboard API keys associated with the requested query
eradman
force-pushed
the
share-link-download
branch
from
b075cc9
to
7cff63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
?api_keyfor dashboards using the path/public/api_keywith dashboard API keys associated with the requested queryHow is this tested?
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
share-link-csv-tsv-downlod.mov