Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node.js 20 to 22 #794

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Bump Node.js 20 to 22 #794

wants to merge 3 commits into from

Conversation

lucydodo
Copy link
Member

@lucydodo lucydodo commented Nov 8, 2024

Node.js transitioned to "Active LTS" with the release of version 22.10.0 on October 29.
Therefore, we will also update the Node.js version accordingly.

The 22.x release line will remain as "Active LTS" until October 2025, and will be in "Maintenance" status until April 2027.

Related: https://nodejs.org/en/blog/release/v22.11.0

@lucydodo lucydodo self-assigned this Nov 8, 2024
@lucydodo lucydodo added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Nov 8, 2024
@justinclift
Copy link
Member

Not sure if Gatsby fully supports NodeJS 22 yet or not?

Doing a quick search online shows this, so maybe not?

@lucydodo
Copy link
Member Author

lucydodo commented Nov 8, 2024

Sorry for late response. At the time of creating the PR, I confirmed that it was working properly in my local environment. However, I just tested it again in the Codespaces environment, and strangely, there was an issue with Python packages not being installed. After adding the relevant code to address this issue, I confirmed that it now works correctly.

@lucydodo ➜ /workspaces/website (bump/nodejs) $ docker-compose run --rm gatsby install
[+] Creating 1/0
 ✔ Network website_default  Created                                                                                                                                                                                                                                              0.1s 
[+] Building 21.9s (11/11) FINISHED                                                                                                                                                                                                                                    docker:default
 => [gatsby internal] load build definition from Dockerfile                                                                                                                                                                                                                      0.0s
 => => transferring dockerfile: 327B                                                                                                                                                                                                                                             0.0s
 => [gatsby internal] load metadata for docker.io/library/node:22-alpine                                                                                                                                                                                                         2.6s
 => [gatsby auth] library/node:pull token for registry-1.docker.io                                                                                                                                                                                                               0.0s
 => [gatsby internal] load .dockerignore                                                                                                                                                                                                                                         0.0s
 => => transferring context: 2B                                                                                                                                                                                                                                                  0.0s
 => [gatsby 1/4] FROM docker.io/library/node:22-alpine@sha256:f265794478aa0b1a23d85a492c8311ed795bc527c3fe7e43453b3c872dcd71a3                                                                                                                                                   8.4s
 => => resolve docker.io/library/node:22-alpine@sha256:f265794478aa0b1a23d85a492c8311ed795bc527c3fe7e43453b3c872dcd71a3                                                                                                                                                          0.0s
 => => sha256:f265794478aa0b1a23d85a492c8311ed795bc527c3fe7e43453b3c872dcd71a3 6.41kB / 6.41kB                                                                                                                                                                                   0.0s
 => => sha256:6fdb5a2cf4f4727c3ec873177330a984caf5c0851ec4bd80ef55da7f634c7722 1.72kB / 1.72kB                                                                                                                                                                                   0.0s
 => => sha256:8847cc4ac5ca55b993ebcc0cd7b994c5e083a606eef81cf4cdb4126169c1d2c7 6.19kB / 6.19kB                                                                                                                                                                                   0.0s
 => => sha256:43c4264eed91be63b206e17d93e75256a6097070ce643c5e8f0379998b44f170 3.62MB / 3.62MB                                                                                                                                                                                   0.4s
 => => sha256:f037f8beafdb35ef5c9a7254780c75e81cf3b2505ab9f8be06edc4a6eca4dbec 49.24MB / 49.24MB                                                                                                                                                                                 1.4s
 => => sha256:6e96017b105b9b791db5b1e1a924abdd3d066861fa8c5c29e4b83dbbea2c8b2d 1.39MB / 1.39MB                                                                                                                                                                                   1.4s
 => => extracting sha256:43c4264eed91be63b206e17d93e75256a6097070ce643c5e8f0379998b44f170                                                                                                                                                                                        0.2s
 => => sha256:5d9c86674f9fdc9f31743b0ceb6769531a0a5d4d9d0b8fb1406f03f92d72c4b4 446B / 446B                                                                                                                                                                                       1.4s
 => => extracting sha256:f037f8beafdb35ef5c9a7254780c75e81cf3b2505ab9f8be06edc4a6eca4dbec                                                                                                                                                                                        1.6s
 => => extracting sha256:6e96017b105b9b791db5b1e1a924abdd3d066861fa8c5c29e4b83dbbea2c8b2d                                                                                                                                                                                        0.0s
 => => extracting sha256:5d9c86674f9fdc9f31743b0ceb6769531a0a5d4d9d0b8fb1406f03f92d72c4b4                                                                                                                                                                                        0.0s
 => [gatsby internal] load build context                                                                                                                                                                                                                                         1.5s
 => => transferring context: 235.42MB                                                                                                                                                                                                                                            1.5s
 => [gatsby 2/4] RUN apk add --no-cache python3 py3-pip make g++     && ln -sf python3 /usr/bin/python     && ln -sf pip3 /usr/bin/pip                                                                                                                                           6.0s
 => [gatsby 3/4] WORKDIR /app                                                                                                                                                                                                                                                    0.1s 
 => [gatsby 4/4] COPY . /app                                                                                                                                                                                                                                                     3.3s 
 => [gatsby] exporting to image                                                                                                                                                                                                                                                  1.5s 
 => => exporting layers                                                                                                                                                                                                                                                          1.5s 
 => => writing image sha256:1bbf81043a56dc6b2ed990a84e99b5c4014ebec39e5e029f695a6f17bc4b34a2                                                                                                                                                                                     0.0s 
 => => naming to docker.io/library/website-gatsby                                                                                                                                                                                                                                0.0s 
 => [gatsby] resolving provenance for metadata file                                                                                                                                                                                                                              0.0s
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning "gatsby > [email protected]" has incorrect peer dependency "@typescript-eslint/eslint-plugin@^4.0.0".
warning "gatsby > [email protected]" has incorrect peer dependency "@typescript-eslint/parser@^4.0.0".
warning "gatsby > [email protected]" has incorrect peer dependency "[email protected]".
warning "gatsby > @typescript-eslint/eslint-plugin > [email protected]" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
warning "gatsby > react-dev-utils > [email protected]" has unmet peer dependency "typescript@>= 2.7".
warning " > [email protected]" has unmet peer dependency "@gatsbyjs/reach-router@^2.0.0".
warning "gatsby-plugin-feed > [email protected]" has unmet peer dependency "graphql@^16.0.0".
warning "gatsby-plugin-netlify > [email protected]" has unmet peer dependency "webpack@^5.2.0".
warning " > [email protected]" has unmet peer dependency "preact@^10.3.4".
warning " > [email protected]" has unmet peer dependency "preact-render-to-string@^5.1.8".
warning "gatsby-plugin-preact > @prefresh/[email protected]" has unmet peer dependency "preact@^10.4.0".
warning "gatsby-plugin-preact > @prefresh/[email protected]" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning "gatsby-plugin-preact > @prefresh/webpack > @prefresh/[email protected]" has unmet peer dependency "preact@^10.0.0".
warning " > [email protected]" has incorrect peer dependency "gatsby@^1.0.0".
warning " > [email protected]" has unmet peer dependency "sass@^1.30.0".
warning "gatsby-plugin-sass > [email protected]" has unmet peer dependency "webpack@^4.36.0 || ^5.0.0".
warning Workspaces can only be enabled in private projects.
[4/4] Building fresh packages...
Done in 227.31s.
@lucydodo ➜ /workspaces/website (bump/nodejs) $ docker compose up -d
[+] Running 1/1
 ✔ Container website-gatsby-1  Started                                                                                                                                                                                                                                           0.5s 
@lucydodo ➜ /workspaces/website (bump/nodejs) $ docker compose exec gatsby node -v
v22.11.0

@justinclift
Copy link
Member

Hmmm, maybe lets hold off on this for a while? That issue I linked to seems to be affecting others as well, and there's no super urgency to merge this?

@lucydodo
Copy link
Member Author

lucydodo commented Nov 9, 2024

Of course we can. :)

@lucydodo lucydodo marked this pull request as draft November 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants