Merge pull request #42 from getsafle/dev

Adding async call to get transaction Size - merge dev to test
getsafle · Dec 4, 2023 · 4ac08e8 · 4ac08e8
2 parents 8f446d1 + 3f41775
commit 4ac08e8
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -60,4 +60,10 @@
 - Updated node version in CI
 - Updated raw transaction paramaters, amount to be accepted in satoshi
 - Added badges
-- Updated license in package json
+- Updated license in package json
+
+### 2.0.3 (2023-12-04)
+
+##### GetFees() update
+
+- Added await for the async call to get transactionSize and updated tests
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@getsafle/vault-bitcoin-controller",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "description": "",
   "engines": {
     "node": ">= 10"

diff --git a/src/index.js b/src/index.js
@@ -171,7 +171,7 @@ class KeyringController {
       const sochainURL = SOCHAIN_BASE_URL + `unspent_outputs/${networkType === TESTNET.NETWORK ? 'BTCTEST' : "BTC"}/${from}`
       const headers = { "API-KEY": SOCHAIN_API_KEY}
 
-      let {transactionSize} = helpers.getTransactionSize(sochainURL, headers)
+      let { transactionSize } = await helpers.getTransactionSize(sochainURL, headers)
 
       return {
         transactionSize,

diff --git a/test/index.js b/test/index.js
@@ -74,7 +74,7 @@ describe('Initialize wallet ', () => {
             const acc = await bitcoinWallet.getAccounts()
             const result = await bitcoinWallet.getFees(acc[0]);
         } catch (err) {
-            assert.equal(err, "Cannot destructure property 'from' of 'transaction' as it is undefined.", "Should throw TyprError")
+            assert.equal(err.message, "Request failed with status code 404", "Should throw 404 error")
         }
 
     })