ref(batching): add compute_batch_size to BatchStep #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MeredithAnya
added a commit
to getsentry/snuba
that referenced
this pull request
Nov 8, 2024
**context**: The work for bulk deleting in snuba has so far included the following: * Added the kafka schemas - getsentry/sentry-kafka-schemas#347 * Adding the new endpoint including producing to the topic - #6440 * Created the topic in production for all env - getsentry/ops#12711 **what's left**: Now that we have the topics created we can finish up the consumer side. - [ ] Add the consumer logic to snuba (This PR) - [ ] Add the consumer deployment to S4S region in the ops repository - [ ] Set up datadog alerts/metrics and other observability **this PR**: It's a bit of a larger PR but it can be reviewed in a couple sections: * The main consumer logic and strategy * This has the logic to create the strategy factory for the consumer and composes the strategy steps. The `strategy.py` file has the details for actually executing the delete query * The `batching.py` file - I have an [arroyo PR](getsentry/arroyo#390) that makes this file obsolete but in the meantime I don't think it needs to block this PR since it will be easy to remove after * The formatters are going to be the only code that someone will need to write in the future when deploying the deletions consumer for a different storage. How one formats the conditions for the `DELETE` query is up to that logic.
untitaker
approved these changes
Nov 18, 2024
I think yes mostly the same, although it seems like in the rust implementation its required, whereas here it defaults to incrementing by 1, I can change the function name though to be consistent |
MeredithAnya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to batch by an amount other than just the count of messages. I have this implement in getsentry/snuba#6510, but it's a lot of copying from arroyo, so it would be nice to have it baked into here.
I'm not sure if we have a ton of other uses for it, but it also seems like it would be relatively harmless to add since by default the batching works the same as beforeLooks like the rust implementation already has something similar (
compute_batch_size) added in a5087b8