fix: avoid partition revocation on paused consumers #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is valid for consumers to be paused for periods of time that exceed the max.poll.interval.ms. we need to continue polling the consumer in this scenario so that the partitions do not get revoked. librdkafka will not yield any new messages when polling a paused consumer
markstory
reviewed
Nov 21, 2024
| # A paused consumer should still poll periodically to avoid it's partitions | ||
| # getting revoked by the broker after reaching the max.poll.interval.ms | ||
| # Polling a paused consumer should never yield a message. | ||
| assert self.__consumer.poll(0.1) is None |
There was a problem hiding this comment.
do we not want to sleep in this elif block?
There was a problem hiding this comment.
it's already effectively got a sleep for 0.1 in there
MeredithAnya
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is valid for consumers to be paused for periods of time that exceed the max.poll.interval.ms.
we need to continue polling the consumer in this scenario so that the partitions do not get revoked.
librdkafka will not yield any new messages when polling a paused consumer