Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update OTEL js custom instructions snippet #10519

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

AbhiPrasad
Copy link
Member

Make sure we only have a single provider

DESCRIBE YOUR PR

Make the experience for https://twitter.com/tim_nolet/status/1806051221112832459 better

reflects getsentry/opentelemetry-js#1

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): ASAP given twitter thread above
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Make sure we only have a single provider
@AbhiPrasad AbhiPrasad requested review from mydea and a team June 26, 2024 20:31
@AbhiPrasad AbhiPrasad self-assigned this Jun 26, 2024
@AbhiPrasad AbhiPrasad requested review from stephanie-anderson and removed request for a team June 26, 2024 20:31
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 9:03pm

Copy link

codecov bot commented Jun 26, 2024

Bundle Report

Changes will increase total bundle size by 2 bytes ⬆️

Bundle name Size Change
sentry-docs-server 7.55MB 9 bytes ⬆️
sentry-docs-edge-server 479.9kB 3 bytes ⬇️
sentry-docs-client 6.22MB 4 bytes ⬇️

@mydea mydea merged commit bdbbfa2 into master Jun 27, 2024
6 checks passed
@mydea mydea deleted the abhi-otel-provider-snippet-fix branch June 27, 2024 09:07
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants