feat(dynamic-sampling): organization settings #11791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 1.1kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
lizokm
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Thanks so much for starting on this! I know it's still in draft. Let me know when you'd like me to take another look. Also, take a look at our current DS docs to see if there's anything we can copy over. (https://docs.sentry.io/product/performance/retention-priorities/)
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Liza Mock <[email protected]>
jan-auer
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Some ideas for information that could be added:
- In the introduction, explain what "dynamic sampling" truly is. As in, what about it is dynamic and what it tries to achieve.
- How does DS fit with sampling in the SDKs and when do I use which?
- What is the default (100% = no sampling)
- How does DS re-compute rates? Note that here we shouldn't give any strict guarantees (e.g. "every 10 minutes") but mention that there's a short sliding window so that DS can adjust to seasonality like on weekends and over night traffic patterns.
- AM2 and AM3 have different capabilities. The sample rates are chosen automatically on AM2, while only on AM3 do you have the new settings screen and control over rates. We should make this clear. @lizokm, how do we usually talk about the plan generations?
- I'd structure this document into multiple larger blocks (not necessarily sections):
- Organization-wide settings, including the sampling mode, project preview, sample rates
- Project-wide settings, which for now are just the priorities
- Connection to other product surface, esp subscription settings and stats
- We can expand the description of the modes, particularly
- How does DS work in each of the modes (i.e. what's the same and what's different)
- How do I think about configuring each of the modes?
- Especially in manual mode, describe the org-level assist. That's where we could use an arcade.
- What happens when I change into this mode?
- On project preview, what do the estimated rates mean, what's the difference between the two time frames, and how do they relate to what DS actually does?
- Retention priorities are now called "[Dynamic] Sampling Priorities", so let's rename them here, too.
jan-auer
reviewed
Nov 15, 2024
|
|
||
| Dynamic Sampling is different from the sampling that you can configure in the Sentry SDKs. The SDK sampling rate is applied before events are sent to Sentry, while Dynamic Sampling is applied after events are received by Sentry. This means that Dynamic Sampling can be used to adjust the sample rate for events that have already been sent to Sentry and only take into account the volume of events that have been received by Sentry. | ||
|
|
||
| Also in contrast to the Dynamic Sampling, the SDK sample rate is never dynamically adjusted. |
There was a problem hiding this comment.
Strictly speaking, "never" isn't true :) traces_sampler allows customers to write their own code for dynamically adjusting sample rates. I think the true differences can rather be summarized as:
- Sampling in SDKs affects how much is captured and sent to Sentry. For high throughput scenarios, this may be necessary to reduce instrumentation overheads.
- To change sample rates in SDKs, one has to update the
traces_sample_rateortraces_samplercallback, which usually requires a new deployment or release. - With dynamic sampling, one can change sample rates without touching the application or SDK. This affects the amount of data stored at Sentry, however, it will not have an effect on how much is sent from the SDKs.
- Dynamic sampling continuously monitors incoming traffic patterns and adjusts fine-grained sample rates within the projects to prioritize more important data. See the sampling priorities for examples.
|
|
||
| <Note> | ||
|
|
||
| Dynamic Sampling priorities are only available on the latest version of our plans, starting from 1M reserved transactions. Anyone in your org with owner or billing-level permissions can update your plan by going to Settings > Subscription, and clicking the "Manage Subscription" button. |
There was a problem hiding this comment.
This will need to be updated. DS priorities are available on AM2 and AM3 (right now this is still correct, as AM2 is latest).
| <Note> | ||
|
|
||
| Retention priorities are only available on the latest version of our plans, starting from 1M reserved transactions. Anyone in your org with owner or billing-level permissions can update your plan by going to Settings > Subscription, and clicking the "Manage Subscription" button. | ||
| Please note that these Dynamic Sampling modes are only available for customers on the AM3 platform. |
There was a problem hiding this comment.
Should we call out that on AM2 there's also DS, the sample rate is chosen by the system based on transaction volume (1M+), and you still have controls for the sampling priorities?
…mpling improve description of recalibration algorithm
Fleshed out configuration mode and sample rates
better short description improved overview more focus on actual features and not just quota filling in mode description improved cross-linking add section for distributed traces clarified distinction between SDK and DS sampling
Advanced mode is an optional addon that can be added
jan-auer
approved these changes
Jan 28, 2025
Also moved warning for deactivation of advanced mode to its distinct paragraph.
jan-auer
approved these changes
Feb 10, 2025
constantinius
deleted the
constantinius/feat/dynamic-sampling/organization-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add section under organization settings to explain the benefits of dynamic sampling and its relevant settings
Closes https://github.com/getsentry/projects/issues/214 and https://github.com/getsentry/projects/issues/213