ref(js): Small fixes to configure sampling structure #13230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
Lms24
approved these changes
Apr 4, 2025
s1gr1d
approved these changes
Apr 4, 2025
docs/platforms/javascript/common/tracing/configure-sampling/index.mdx
Outdated
Show resolved
Hide resolved
| @@ -125,7 +127,7 @@ tracesSampler: (samplingContext) => { | |||
|
|
|||
| When multiple sampling mechanisms could apply, Sentry follows this order of precedence: | |||
|
|
|||
| - If `tracesSampler` is defined, its decision is used. Although the `tracesSampler` can override the parent sampling decision, most users will want to ensure their `tracesSampler` respects the parent sampling decision. | |||
| - If `tracesSampler` is defined, its decision is used. Although the `tracesSampler` can override the parent sampling decision, most users will want to ensure their `tracesSampler` respects the parent sampling decision. | |||
There was a problem hiding this comment.
It might be hard to understand what to "parent sampling decision" is, if one is not super familiar with tracing.
There was a problem hiding this comment.
true, we can adjust this in a follow up maybe! Always hard to explain these things properly 😬
…dex.mdx Co-authored-by: Sigrid Huemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this is a bit off now, so fixing/aligning doc structure here.