-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin macos-15 build runner #3754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ever changing flow of pin/unpin...
We're getting this error on the macos-15 runner:
Looks like that runner doesn't (yet) include the android build tools. Workaround described here: # https://github.com/actions/runner-images/issues/10814
- name: Workaround build-tools issue
run: |
curl https://dl.google.com/android/repository/build-tools_r35_macosx.zip > $ANDROID_HOME/build-tools_r35_macosx.zip
cd $ANDROID_HOME
mkdir build-tools
unzip build-tools_r35_macosx.zip
mv android-15 build-tools/35.0.0 |
Now getting an error about mono (when running the tests on macos):
|
Is this a integration test flake @vaind? I actually don't understand the failure |
It's not the reason the integration test failed... that was because of this:
The Android SDKs obviously aren't included on the macos-15 runner, so we need to install these ourselves. I already added that for the build step: sentry-dotnet/.github/workflows/build.yml Lines 126 to 130 in e6e6424
With any luck, this does the same for the integration tests: sentry-dotnet/integration-test/cli.Tests.ps1 Lines 145 to 152 in 40b9757
It's kind of painful to work through all these issues since they only happen on CI... and now we're getting to the last ones (in the integration tests) there's a minimum 60-90 minute wait after each change to see if it worked. |
Resolves #3752
#skip-changelog