Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logrus-hook): Don't throw error if sentry event is dropped #579

Closed
wants to merge 1 commit into from
Closed

fix(logrus-hook): Don't throw error if sentry event is dropped #579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion logrus/logrusentry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ func (h *Hook) Fire(entry *logrus.Entry) error {
if h.fallback != nil {
return h.fallback(entry)
}
return errors.New("failed to send to sentry")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm questioning the usefulness of handling the return value of CaptureEvent altogether. By default, the ID is always returned, even if the HTTPTransport does not successfully submit the event to Sentry, as we do not have a back channel to the main thread. So this only applies when using the HTTPSyncTransport.

}
return nil
}
Expand Down