Skip to content

Commit

Permalink
Remove debug logs when searching for OpenTelemetry marker classes (#4091
Browse files Browse the repository at this point in the history
)

* Remove debug logs when searching for OpenTelemetry marker classes

* changelog
  • Loading branch information
adinauer authored Jan 23, 2025
1 parent e2e1435 commit 467b52b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
### Fixes

- Avoid logging an error when a float is passed in the manifest ([#4031](https://github.com/getsentry/sentry-java/pull/4031))
- Remove `java.lang.ClassNotFoundException` debug logs when searching for OpenTelemetry marker classes ([#4091](https://github.com/getsentry/sentry-java/pull/4091))
- There was up to three of these, one for `io.sentry.opentelemetry.agent.AgentMarker`, `io.sentry.opentelemetry.agent.AgentlessMarker` and `io.sentry.opentelemetry.agent.AgentlessSpringMarker`.
- These were not indicators of something being wrong but rather the SDK looking at what is available at runtime to configure itself accordingly.

## 8.0.0

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.sentry.opentelemetry;

import io.sentry.NoOpLogger;
import io.sentry.SentryOpenTelemetryMode;
import io.sentry.SentryOptions;
import io.sentry.util.LoadClass;
Expand Down Expand Up @@ -29,15 +30,15 @@ public static void applyIgnoredSpanOrigins(
final @NotNull SentryOpenTelemetryMode openTelemetryMode = options.getOpenTelemetryMode();
if (SentryOpenTelemetryMode.AUTO.equals(openTelemetryMode)) {
if (loadClass.isClassAvailable(
"io.sentry.opentelemetry.agent.AgentMarker", options.getLogger())) {
"io.sentry.opentelemetry.agent.AgentMarker", NoOpLogger.getInstance())) {
return SpanUtils.ignoredSpanOriginsForOpenTelemetry(SentryOpenTelemetryMode.AGENT);
}
if (loadClass.isClassAvailable(
"io.sentry.opentelemetry.agent.AgentlessMarker", options.getLogger())) {
"io.sentry.opentelemetry.agent.AgentlessMarker", NoOpLogger.getInstance())) {
return SpanUtils.ignoredSpanOriginsForOpenTelemetry(SentryOpenTelemetryMode.AGENTLESS);
}
if (loadClass.isClassAvailable(
"io.sentry.opentelemetry.agent.AgentlessSpringMarker", options.getLogger())) {
"io.sentry.opentelemetry.agent.AgentlessSpringMarker", NoOpLogger.getInstance())) {
return SpanUtils.ignoredSpanOriginsForOpenTelemetry(
SentryOpenTelemetryMode.AGENTLESS_SPRING);
}
Expand Down

0 comments on commit 467b52b

Please sign in to comment.