Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android-ndk): add api for getting debug images by addresses #4089

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jan 21, 2025

question: can I push this change onto a v7 branch? We cannot bump to Android v8 at this moment because we also depend on min android api 19 which has been bumped to 21 here. if not possible we'll mark this as a Flutter v9 feature

📜 Description

Adds debug images loader API for getting images by addresses

💡 Motivation and Context

On Flutter we are currently loading all available debug images which can sometimes range up to 300 images but in most cases only 1 is actually used so this is much more efficient and the envelope is therefore smaller

Closes #3925

#skip-changelog

💚 How did you test it?

Unit test, e2e test with Flutter app

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 0632191

@buenaflor
Copy link
Contributor Author

cc @markushi can you have a quick look pls

@buenaflor buenaflor requested a review from lcian as a code owner January 28, 2025 15:58
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 410.94 ms 491.28 ms 80.35 ms
Size 1.58 MiB 2.21 MiB 638.68 KiB

Previous results on branch: feat/internal-sdk-debug-image-fetching-per-stacktrace

Startup times

Revision Plain With Sentry Diff
86c73f9 402.86 ms 441.96 ms 39.10 ms
a40047a 339.33 ms 467.08 ms 127.76 ms
ce9de6a 428.98 ms 502.62 ms 73.64 ms

App size

Revision Plain With Sentry Diff
86c73f9 1.65 MiB 2.31 MiB 678.17 KiB
a40047a 1.65 MiB 2.31 MiB 678.86 KiB
ce9de6a 1.65 MiB 2.31 MiB 678.86 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Add internal hybrid sdk api for fetching debug images that were referenced in the stacktrace
3 participants