Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request details to transactions created through OpenTelemetry #4098

Merged
merged 10 commits into from
Jan 24, 2025

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jan 23, 2025

📜 Description

Use OpenTelemetry span attributes and create request

Fixes both the HTTP request method column in the transaction list as well as the request details on the transaction detail page.
Screenshot 2025-01-23 at 12 01 32
Screenshot 2025-01-23 at 12 01 46

Things I tried but didn't work out:

Sending a relative URL in the request isn't displayed in the Sentry UI
Screenshot 2025-01-23 at 13 54 38

Sending url.path, server.address etc. in span.data it also isn't displayed in Sentry UI
Screenshot 2025-01-23 at 13 52 35

💡 Motivation and Context

Fixes #4047

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against db933d5

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 442.38 ms 514.43 ms 72.05 ms
Size 1.65 MiB 2.31 MiB 678.16 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: feat/request-for-otel

Startup times

Revision Plain With Sentry Diff
06d09f2 425.84 ms 482.20 ms 56.36 ms
8daad21 433.21 ms 489.77 ms 56.56 ms
3504741 410.71 ms 416.60 ms 5.89 ms
880bea5 430.57 ms 495.62 ms 65.05 ms

App size

Revision Plain With Sentry Diff
06d09f2 1.65 MiB 2.31 MiB 677.61 KiB
8daad21 1.65 MiB 2.31 MiB 677.61 KiB
3504741 1.65 MiB 2.31 MiB 677.61 KiB
880bea5 1.65 MiB 2.31 MiB 677.59 KiB

@adinauer adinauer merged commit 29a4185 into main Jan 24, 2025
38 checks passed
@adinauer adinauer deleted the feat/request-for-otel branch January 24, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transactions created via OpenTelemetry don't show request method in Sentry UI
2 participants