-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request
details to transactions created through OpenTelemetry
#4098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano,
markushi and
lcian
as code owners
January 23, 2025 11:02
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
00c8eeb | 415.32 ms | 428.08 ms | 12.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
00c8eeb | 1.70 MiB | 2.36 MiB | 671.98 KiB |
Previous results on branch: feat/request-for-otel
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
06d09f2 | 425.84 ms | 482.20 ms | 56.36 ms |
8daad21 | 433.21 ms | 489.77 ms | 56.56 ms |
3504741 | 410.71 ms | 416.60 ms | 5.89 ms |
880bea5 | 430.57 ms | 495.62 ms | 65.05 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
06d09f2 | 1.65 MiB | 2.31 MiB | 677.61 KiB |
8daad21 | 1.65 MiB | 2.31 MiB | 677.61 KiB |
3504741 | 1.65 MiB | 2.31 MiB | 677.61 KiB |
880bea5 | 1.65 MiB | 2.31 MiB | 677.59 KiB |
lcian
approved these changes
Jan 23, 2025
...ntelemetry/sentry-opentelemetry-core/src/test/kotlin/OpenTelemetryAtrtibutesExtractorTest.kt
Outdated
Show resolved
Hide resolved
...entelemetry-core/src/main/java/io/sentry/opentelemetry/OpenTelemetryAttributesExtractor.java
Show resolved
Hide resolved
lcian
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use OpenTelemetry span attributes and create
request
Fixes both the HTTP request method column in the transaction list as well as the request details on the transaction detail page.
Things I tried but didn't work out:
Sending a relative URL in the
request
isn't displayed in the Sentry UISending
url.path
,server.address
etc. inspan.data
it also isn't displayed in Sentry UI💡 Motivation and Context
Fixes #4047
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps