Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky RateLimiter test #4100

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Fix flaky RateLimiter test #4100

merged 3 commits into from
Jan 23, 2025

Conversation

stefanosiano
Copy link
Member

📜 Description

#skip-changelog

💡 Motivation and Context

RateLimiterTest close cancels the timer was flaky
Now it uses reflection to assert the timer was cancelled

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano stefanosiano marked this pull request as ready for review January 23, 2025 15:57
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 456.19 ms 473.73 ms 17.54 ms
Size 1.65 MiB 2.31 MiB 677.61 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

@stefanosiano stefanosiano merged commit 2872e8e into main Jan 23, 2025
37 of 38 checks passed
@stefanosiano stefanosiano deleted the fix/flaky-ratelimiter-test branch January 23, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants