Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JavaDoc to SentryOptions.ignoredTransactions,ignoredSpanOrigins,ignoredCheckIns #4110

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Add JavaDoc to SentryOptions.ignoredTransactions,ignoredSpanOrigins,ignoredCheckIns #4110

merged 4 commits into from
Jan 29, 2025

Conversation

lcian
Copy link
Member

@lcian lcian commented Jan 27, 2025

#skip-changelog

📜 Description

Adds JavaDoc to some fields and methods in SentryOptions.

💡 Motivation and Context

Closes #4101

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7451cff

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 433.22 ms 499.06 ms 65.84 ms
Size 1.65 MiB 2.31 MiB 678.17 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: feat/javadoc-ignore-options

Startup times

Revision Plain With Sentry Diff
24af825 388.88 ms 469.18 ms 80.30 ms

App size

Revision Plain With Sentry Diff
24af825 1.65 MiB 2.31 MiB 678.17 KiB

adinauer
adinauer approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions, otherwise LGTM. Thanks!

sentry/src/main/java/io/sentry/SentryOptions.java Outdated Show resolved Hide resolved
sentry/src/main/java/io/sentry/SentryOptions.java Outdated Show resolved Hide resolved
sentry/src/main/java/io/sentry/SentryOptions.java Outdated Show resolved Hide resolved
sentry/src/main/java/io/sentry/SentryOptions.java Outdated Show resolved Hide resolved
sentry/src/main/java/io/sentry/SentryOptions.java Outdated Show resolved Hide resolved
sentry/src/main/java/io/sentry/SentryOptions.java Outdated Show resolved Hide resolved
sentry/src/main/java/io/sentry/SentryOptions.java Outdated Show resolved Hide resolved
sentry/src/main/java/io/sentry/SentryOptions.java Outdated Show resolved Hide resolved
sentry/src/main/java/io/sentry/SentryOptions.java Outdated Show resolved Hide resolved
@lcian lcian merged commit 880dc4f into main Jan 29, 2025
37 checks passed
@lcian lcian deleted the feat/javadoc-ignore-options branch January 29, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add JavaDoc to some methods in SentryOptions
2 participants
@lcian @adinauer