Review feedback

getsentry · Jul 12, 2024 · 7fbd56b · 7fbd56b
1 parent 1a2f081
commit 7fbd56b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,8 +15,7 @@
 The `enableTracing` option has been deprecated and will be removed in the next major version. We recommend removing it
 in favor of the `tracesSampleRate` and `tracesSampler` options. If you want to enable performance monitoring, please set
 the `tracesSampleRate` to a sample rate of your choice, or provide a sampling function as `tracesSampler` option
-instead. If you wan't to disable performance monitoring, remove the `tracesSampler` option and set the
-`tracesSampleRate` to `0` or `undefined`.
+instead. If you wan't to disable performance monitoring, remove the `tracesSampler` and `tracesSampleRate` options.
 
 Work in this release was contributed by @GitSquared. Thank you for your contribution!
 

diff --git a/packages/core/src/utils/hasTracingEnabled.ts b/packages/core/src/utils/hasTracingEnabled.ts
@@ -17,6 +17,7 @@ export function hasTracingEnabled(
   }
 
   const options = maybeOptions || getClientOptions();
+  // eslint-disable-next-line deprecation/deprecation
   return !!options && (options.enableTracing || 'tracesSampleRate' in options || 'tracesSampler' in options);
 }
 

diff --git a/packages/types/src/options.ts b/packages/types/src/options.ts
@@ -93,9 +93,9 @@ export interface ClientOptions<TO extends BaseTransportOptions = BaseTransportOp
    * This will set the `tracesSampleRate` to the recommended default of `1.0` if `tracesSampleRate` is undefined.
    * Note that `tracesSampleRate` and `tracesSampler` take precedence over this option.
    *
-   * @deprecated This option is deprecated and will be removed in the next major version. If you want to enable performance monitoring, please set the `tracesSampleRate` or
-   * `tracesSampler` options instead. If you wan't to disable performance monitoring, remove the `tracesSampler` option
-   * and set the `tracesSampleRate` to `0` or `undefined`.
+   * @deprecated This option is deprecated and will be removed in the next major version. If you want to enable performance
+   * monitoring, please use the `tracesSampleRate` or `tracesSampler` options instead. If you wan't to disable performance
+   * monitoring, remove the `tracesSampler` and `tracesSampleRate` options.
    */
   enableTracing?: boolean;
-Original file line number
+Diff line change
@@ Expand Up / @@ -17,6 +17,7 @@ export function hasTracingEnabled( @@
       }
       const options = maybeOptions || getClientOptions();
+      // eslint-disable-next-line deprecation/deprecation
       return !!options && (options.enableTracing || 'tracesSampleRate' in options || 'tracesSampler' in options);
     }
@@ Expand Down @@