Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
mydea committed Dec 18, 2024
1 parent 0c2bfbe commit 80d832f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 30 deletions.
5 changes: 2 additions & 3 deletions packages/profiling-node/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@

## Installation

Profiling works as an extension of tracing so you will need both @sentry/node and @sentry/profiling-node installed. The
minimum required major version of @sentry/node that supports profiling is 7.x.
Profiling works as an extension of tracing so you will need both @sentry/node and @sentry/profiling-node installed.

```bash
# Using yarn
Expand Down Expand Up @@ -84,7 +83,7 @@ After the binaries are built, you should see them inside the profiling-node/lib

### Prebuilt binaries

We currently ship prebuilt binaries for a few of the most common platforms and node versions (v16-22).
We currently ship prebuilt binaries for a few of the most common platforms and node versions (v18-22).

- macOS x64
- Linux ARM64 (musl)
Expand Down
27 changes: 0 additions & 27 deletions scripts/ci-unit-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,7 @@ import * as childProcess from 'child_process';
import * as fs from 'fs';
import * as path from 'path';

type NodeVersion = '18' | '20' | '21';

interface VersionConfig {
ignoredPackages: Array<`@${'sentry' | 'sentry-internal'}/${string}`>;
}

const UNIT_TEST_ENV = process.env.UNIT_TEST_ENV as 'node' | 'browser' | undefined;

const CURRENT_NODE_VERSION = process.version.replace('v', '').split('.')[0] as NodeVersion;

const RUN_AFFECTED = process.argv.includes('--affected');

// These packages are tested separately in CI, so no need to run them here
Expand All @@ -35,19 +26,6 @@ const BROWSER_TEST_PACKAGES = [
'@sentry/wasm',
];

// These are Node-version specific tests that need to be skipped because of support
const SKIP_TEST_PACKAGES: Record<NodeVersion, VersionConfig> = {
'18': {
ignoredPackages: [],
},
'20': {
ignoredPackages: [],
},
'21': {
ignoredPackages: [],
},
};

function getAllPackages(): string[] {
const { workspaces }: { workspaces: string[] } = JSON.parse(
fs.readFileSync(path.join(process.cwd(), 'package.json'), 'utf-8'),
Expand Down Expand Up @@ -80,11 +58,6 @@ function runTests(): void {
BROWSER_TEST_PACKAGES.forEach(pkg => ignores.add(pkg));
}

const versionConfig = SKIP_TEST_PACKAGES[CURRENT_NODE_VERSION];
if (versionConfig) {
versionConfig.ignoredPackages.forEach(dep => ignores.add(dep));
}

if (RUN_AFFECTED) {
runAffectedTests(ignores);
} else {
Expand Down

0 comments on commit 80d832f

Please sign in to comment.